[Lldb-commits] [lldb] r107575 - in /lldb/trunk/test: function_types/TestFunctionTypes.py lldbtest.py

[Johnny Chen]

Author: johnny
Date: Sat Jul  3 15:41:42 2010
New Revision: 107575

URL: http://llvm.org/viewvc/llvm-project?rev=107575&view=rev
Log:
Make it fail fast if 'mydir' attribute is not overridden by subclasses of
lldbtest.TestBase.

Also removed some debug prints.

Modified:
    lldb/trunk/test/function_types/TestFunctionTypes.py
    lldb/trunk/test/lldbtest.py

Modified: lldb/trunk/test/function_types/TestFunctionTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/function_types/TestFunctionTypes.py?rev=107575&r1=107574&r2=107575&view=diff
==============================================================================
--- lldb/trunk/test/function_types/TestFunctionTypes.py (original)
+++ lldb/trunk/test/function_types/TestFunctionTypes.py Sat Jul  3 15:41:42 2010
@@ -14,8 +14,6 @@
         res = self.res
         exe = os.path.join(os.getcwd(), "a.out")
         self.ci.HandleCommand("file " + exe, res)
-        print "os.getcwd(): ", os.getcwd()
-        print "file a.out :", res.GetOutput()
         self.assertTrue(res.Succeeded())
 
         # Break inside the main.

Modified: lldb/trunk/test/lldbtest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lldbtest.py?rev=107575&r1=107574&r2=107575&view=diff
==============================================================================
--- lldb/trunk/test/lldbtest.py (original)
+++ lldb/trunk/test/lldbtest.py Sat Jul  3 15:41:42 2010
@@ -35,9 +35,12 @@
     """This LLDB abstract base class is meant to be subclassed."""
 
     # The concrete subclass should override this attribute.
-    mydir = ""
+    mydir = None
 
     def setUp(self):
+        # Fail fast if 'mydir' attribute is not overridden.
+        if not self.mydir or len(self.mydir) == 0:
+            raise Exception("Subclasses must override the 'mydir' attribute.")
         # Save old working directory.
         self.oldcwd = os.getcwd()
 
@@ -49,10 +52,9 @@
         # Create the debugger instance if necessary.
         try:
             self.dbg = lldb.DBG
-        except NameError:
-            self.dbg = lldb.SBDebugger.Create()
         except AttributeError:
             self.dbg = lldb.SBDebugger.Create()
+
         if not self.dbg.IsValid():
             raise Exception('Invalid debugger instance')