[Lldb-commits] [lldb] r105748 - /lldb/trunk/source/Core/UUID.cpp

[Chris Lattner]

On Jun 9, 2010, at 12:36 PM, Greg Clayton wrote:

> Author: gclayton
> Date: Wed Jun  9 14:36:54 2010
> New Revision: 105748
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=105748&view=rev
> Log:
> For header includes we are currently trying to adopt some aspects of the 
> Google C++ coding guidelines where includes are done as:
> 
> 1 - the header file for the current source file
> 2 - C includes
> 3 - C++ includes
> 4 - external project includes
> 5 - current project includes

Hey Greg,

Any objection to migrating to the llvm style?
http://llvm.org/docs/CodingStandards.html#scf_includes
http://llvm.org/docs/CodingStandards.html#hl_dontinclude

Also, in C++ code, it is generally better to #include <cstdio> instead of <stdio.h>, because it is technically more portable.  Any objection to eventually migrating this way?

-Chris


> 
> 
> 
> Modified:
>    lldb/trunk/source/Core/UUID.cpp
> 
> Modified: lldb/trunk/source/Core/UUID.cpp
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/UUID.cpp?rev=105748&r1=105747&r2=105748&view=diff
> ==============================================================================
> --- lldb/trunk/source/Core/UUID.cpp (original)
> +++ lldb/trunk/source/Core/UUID.cpp Wed Jun  9 14:36:54 2010
> @@ -9,13 +9,14 @@
> 
> #include "lldb/Core/UUID.h"
> // C Includes
> +#include <string.h>
> +#include <stdio.h>
> +#include <ctype.h>
> +
> // C++ Includes
> // Other libraries and framework includes
> // Project includes
> #include "lldb/Core/Stream.h"
> -#include <string.h>
> -#include <stdio.h>
> -#include <ctype.h>
> 
> using namespace lldb_private;
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits