[Lldb-commits] [lldb] r105724 - /lldb/trunk/source/Core/Args.cpp

[Eli Friedman]

On Wed, Jun 9, 2010 at 1:29 PM, Caroline Tice <ctice at apple.com> wrote:
> Hi Eli,
>
> I'm very glad you are so interested in LLDB and taking such an active part
> to help us in our
> development.  About removing dead code:  I don't think this particular case
> is a problem, but LLDB is
> still in fairly early development.  Sometimes there is dead code that really
> is dead and probably
> should be removed, but other times there might be seemingly dead code that
> was really put there
> as a reminder of something to write or hook up in the future.  Please don't
> remove seemingly dead
> code for now.  Thanks!

Okay, I'll try to be more careful about that in the future.

-Eli

> -- Caroline Tice
> ctice at apple.com
> On Jun 9, 2010, at 3:59 AM, Eli Friedman wrote:
>
> Author: efriedma
> Date: Wed Jun  9 05:59:23 2010
> New Revision: 105724
>
> URL: http://llvm.org/viewvc/llvm-project?rev=105724&view=rev
> Log:
> Remove unused class.
>
>
> Modified:
>    lldb/trunk/source/Core/Args.cpp
>
> Modified: lldb/trunk/source/Core/Args.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Args.cpp?rev=105724&r1=105723&r2=105724&view=diff
> ==============================================================================
> --- lldb/trunk/source/Core/Args.cpp (original)
> +++ lldb/trunk/source/Core/Args.cpp Wed Jun  9 05:59:23 2010
> @@ -9,8 +9,7 @@
>
> // C Includes
> #include <getopt.h>
> -#include <histedit.h>
> -
> +#include <cstdlib>
> // C++ Includes
> // Other libraries and framework includes
> // Project includes
> @@ -21,93 +20,6 @@
> #include "lldb/Core/Options.h"
> #include "lldb/Interpreter/CommandReturnObject.h"
>
> -namespace lldb_private {
> -
> -class Tokenizer
> -{
> -public:
> -    Tokenizer (const char *separator_chars = NULL) :
> -        m_tokenizer(NULL)
> -    {
> -        m_tokenizer = ::tok_init (separator_chars);
> -    }
> -
> -    ~Tokenizer ()
> -    {
> -        if (m_tokenizer)
> -        {
> -            ::tok_end (m_tokenizer);
> -            m_tokenizer = NULL;
> -        }
> -    }
> -
> -    void
> -    Reset ()
> -    {
> -        assert (m_tokenizer);
> -        ::tok_reset (m_tokenizer);
> -    }
> -
> -    int
> -    TokenizeLineInfo (const ::LineInfo *line_info)
> -    {
> -        assert (m_tokenizer);
> -        return ::tok_line (m_tokenizer,
> -                           line_info,
> -                           &m_argc,
> -                           &m_argv,
> -                           &m_cursor_arg_index,
> -                           &m_cursor_arg_offset);
> -    }
> -
> -    int
> -    TokenizeCString (const char *cstr)
> -    {
> -        assert (m_tokenizer);
> -        m_cursor_arg_index = -1;
> -        m_cursor_arg_offset = -1;
> -        return ::tok_str (m_tokenizer,
> -                          cstr,
> -                          &m_argc,
> -                          &m_argv);
> -    }
> -
> -
> -    int
> -    GetArgCount () const
> -    {
> -        return m_argc;
> -    }
> -
> -    const char **
> -    GetArgVector () const
> -    {
> -        return m_argv;
> -    }
> -
> -    int
> -    GetCursoreArgIndex () const
> -    {
> -        return m_cursor_arg_index;
> -    }
> -
> -    int
> -    GetCursoreArgOffset () const
> -    {
> -        return m_cursor_arg_offset;
> -    }
> -
> -
> -protected:
> -    struct tokenizer* m_tokenizer;
> -    const char **m_argv;
> -    int m_argc;
> -    int m_cursor_arg_index;
> -    int m_cursor_arg_offset;
> -};
> -
> -} // namespace lldb_private
> -
> using namespace lldb;
> using namespace lldb_private;
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
>