[libcxx-dev] Contributing debug visualizers for libc++

Wed Jul 17 12:53:21 PDT 2019

What do the tests look like? Is that something that we can reasonably run as part of the libc++ test suite?

Louis

> On Jul 11, 2019, at 14:51, Sterling Augustine via libcxx-dev <libcxx-dev at lists.llvm.org> wrote:
> 
> We have been on a bit of a sprint for gdb libc++ pretty printers over the last week or two. We have a reasonable set right now, with more coming. And a very good test harness and set of tests too.
> 
> We would love to get a good upstreaming story here, and it is high on my list of priorities.
> 
> On Thu, Jul 11, 2019 at 11:48 AM Eric Christopher <echristo at gmail.com <mailto:echristo at gmail.com>> wrote:
> Relatedly Sterling has been working with people on gdb pretty printers
> and so having a place in the libc++ sources would be great. :)
> 
> Also things like testing that they don't break should be at least
> thought about a little bit.
> 
> -eric
> 
> On Wed, Jul 10, 2019 at 12:47 PM Nico Weber via libcxx-dev
> <libcxx-dev at lists.llvm.org <mailto:libcxx-dev at lists.llvm.org>> wrote:
> >
> > Friendly ping :)
> >
> > On Wed, May 8, 2019 at 2:33 PM Nico Weber <thakis at chromium.org <mailto:thakis at chromium.org>> wrote:
> >>
> >> Sorry about the additional email, but the file has moved around. The new location is at https://cs.chromium.org/chromium/src/build/config/c%2B%2B/libc%2B%2B.natvis?q=file:libc...natvis&sq=package:chromium&g=0&l=1 <https://cs.chromium.org/chromium/src/build/config/c%2B%2B/libc%2B%2B.natvis?q=file:libc...natvis&sq=package:chromium&g=0&l=1>
> >>
> >> On Tue, May 7, 2019 at 2:48 PM Nico Weber <thakis at chromium.org <mailto:thakis at chromium.org>> wrote:
> >>>
> >>> Thanks for the quick response! No rush, next week sounds great :)
> >>>
> >>> On Tue, May 7, 2019 at 2:46 PM Marshall Clow <mclow.lists at gmail.com <mailto:mclow.lists at gmail.com>> wrote:
> >>>>
> >>>>
> >>>>
> >>>> On Tue, May 7, 2019 at 12:08 PM Nico Weber via libcxx-dev <libcxx-dev at lists.llvm.org <mailto:libcxx-dev at lists.llvm.org>> wrote:
> >>>>>
> >>>>> Hi,
> >>>>>
> >>>>> Chromium now uses a statically linked libc++ on most platforms. One piece of feedback we got from devs is that they don't want the switch to libc++ to impede their debugging experience, so we wrote a natvis file that teaches Microsoft's debuggers how to display libc++ types. We're also using https://github.com/koutheir/libcxx-pretty-printers <https://github.com/koutheir/libcxx-pretty-printers> to achieve the same for gdb.
> >>>>>
> >>>>> Other projects are probably also interested in having good libc++ support in their debuggers. Would there be interest to have these debug visualizers right in the libc++ repository, either somewhere in utils/, or in a new misc/ directory, or what have you?
> >>>>>
> >>>>> We'd gladly contribute the natvis file [1] under LLVM's license.
> >>>>>
> >>>>> (libcxx-pretty-printers is a separate project not done by us. If this thread goes somewhere, I'm planning to ask the upstream maintainers if they'd be open to relicensing and contributing the gdb pretty printers to upstream libcxx as well, but they might not agree. If they don't, we (chromium) might want to write libc++ pretty printers for gdb from scratch and contribute those, but not sure.)
> >>>>>
> >>>>
> >>>> Nico --
> >>>>
> >>>> I'm going to apologize in advance for a slow response, since I (and Louis) are at C++Now this week.
> >>>> This sounds really interesting, and I'll take a look at this early next week.
> >>>>
> >>>> -- Marshall
> >>>>
> >
> > _______________________________________________
> > libcxx-dev mailing list
> > libcxx-dev at lists.llvm.org <mailto:libcxx-dev at lists.llvm.org>
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-dev <https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-dev>
> _______________________________________________
> libcxx-dev mailing list
> libcxx-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libcxx-dev/attachments/20190717/30e58156/attachment.html>