[libcxx-dev] Removing deprecated <ext/hash_set>, <ext/hash_map> and <ext/__hash>

Louis Dionne via libcxx-dev libcxx-dev at lists.llvm.org
Tue Feb 5 05:28:32 PST 2019



> On Feb 5, 2019, at 01:53, Dimitry Andric <dimitry at andric.com> wrote:
> 
> Well, it would be interesting to do a FreeBSD ports exp-run with these headers removed.  You'd be surprised how much software is out there using obsolete, experimental and/or not even officially existing headers. :-)

Please do so and report on the results. One solution might be to ship those headers outside of libc++ for projects that still need them.

Louis

> 
> -Dimitry
> 
>> On 4 Feb 2019, at 20:31, Louis Dionne via libcxx-dev <libcxx-dev at lists.llvm.org <mailto:libcxx-dev at lists.llvm.org>> wrote:
>> 
>> Hi,
>> 
>> Libc++ has been shipping the <ext/hash_set>, <ext/hash_map> and <ext/__hash> headers for a while and they are deprecated. Those headers contain data structures like __gnu_cxx::hash_map that have replacements like std::unordered_map. I would like to remove those headers. I've put up a patch for review but I won't commit it until we have a sort of plan because I know some people have expressed feelings about removing the headers in the past: https://reviews.llvm.org/D57688 <https://reviews.llvm.org/D57688>.
>> 
>> FWIW, I've compiled a large code base with that patch and I didn't get any trouble. I suspect the amount of breakage this will cause is manageable especially if we give advance notice, but others might disagree.
>> 
>> Is anybody opposed to removing those headers? If you're opposed to the removal, please explain why and what removal timeline/plan would work for you.
>> 
>> Thanks!
>> Louis
>> 
>> _______________________________________________
>> libcxx-dev mailing list
>> libcxx-dev at lists.llvm.org <mailto:libcxx-dev at lists.llvm.org>
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-dev
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libcxx-dev/attachments/20190205/695de81c/attachment.html>


More information about the libcxx-dev mailing list