[libcxx-commits] [libcxx] [libc++][format] Don't leave the output buffer full after a bulk write (PR #226791)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 28 03:26:11 PDT 2026


================
@@ -250,6 +250,10 @@ class __output_buffer {
       __first += __chunk;
       __n -= __chunk;
     } while (__n);
+
+    // push_back needs a free code unit, which the last chunk may have used.
----------------
philnik777 wrote:

I'm actually kinda wondering whether it would be better to flip the loop, i.e. use up the `__available()` capacity and only then request more space via `__prepare_write()`.

https://github.com/llvm/llvm-project/pull/226791


More information about the libcxx-commits mailing list