[libcxx-commits] [libcxx] [libc++][format] Don't leave the output buffer full after a bulk write (PR #226791)

A. Jiang via libcxx-commits libcxx-commits at lists.llvm.org
Sun Sep 27 08:42:45 PDT 2026


================
@@ -250,6 +250,10 @@ class __output_buffer {
       __first += __chunk;
       __n -= __chunk;
     } while (__n);
+
+    // push_back needs a free code unit, which the last chunk may have used.
+    if (__size_ == __capacity_)
+      __prepare_write(0);
----------------
frederick-vs-ja wrote:

Mostly fine to me, but I'm afraid that this could cause unnecessary allocation...

https://github.com/llvm/llvm-project/pull/226791


More information about the libcxx-commits mailing list