[libcxx-commits] [libcxx] [libc++] Address missing cmake in libcxx.test.googlebenchmark (PR #225590)

[Louis Dionne via libcxx-commits]

ldionne wrote:

> This is the first time we see a llvm component depends on cmake in PATH or in CMAKE.

That's far from the truth, most of our build bots use `cmake` unqualified and end up using whatever they find in the `PATH`.

I think there is a path forward here by adding more parameters to `params.py` but TBH I find the approach of reverting https://github.com/llvm/llvm-project/pull/224192 (in https://github.com/llvm/llvm-project/pull/225620) before we've had time to discuss to be cavalier.

Fuchsia does not have pre-commit CI bots, we've been asking for them for years and they have been promised but they never come. Furthermore, this notion of "hermetic builds" might be something that you rely on, and it might have a lot of value (I don't dispute that), but it's not something that has ever been on libc++'s radar AFAICT. @petrhosek when do we finally resolve this point of friction between our projects by adding Fuchsia runners to our pre-commit CI?

I will take over this patch to re-land the original code w/ additional lit parameters for threading the CMake binaries through.

https://github.com/llvm/llvm-project/pull/225590