[libcxx-commits] [libcxx] [libc++] Address missing cmake in libcxx.test.googlebenchmark (PR #225590)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Sep 22 23:56:40 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r origin/main...HEAD libcxx/utils/libcxx/test/googlebenchmark.py
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- googlebenchmark.py	2026-09-23 06:51:41.000000 +0000
+++ googlebenchmark.py	2026-09-23 06:56:01.637059 +0000
@@ -199,18 +199,22 @@
     if not os.path.exists(os.path.join(buildDir, "CMakeCache.txt")):
         litConfig.note("Configuring GoogleBenchmark in {}".format(buildDir))
         compiler = _expand(config, _getSubstitution("%{cxx}", config))
         configure_cmd = [
             cmake,
-            "-S", SOURCE_DIR,
-            "-B", buildDir,
+            "-S",
+            SOURCE_DIR,
+            "-B",
+            buildDir,
             "-DCMAKE_BUILD_TYPE=Release",
             "-DCMAKE_CXX_COMPILER={}".format(compiler),
             "-DCMAKE_CXX_FLAGS={}".format(" ".join(flags)),
             # Set CMAKE_EXE_LINKER_FLAGS in addition to BENCHMARK_CXX_LIBRARIES since we
             # need CMake's own probe executables to have the right linker flags.
-            "-DCMAKE_EXE_LINKER_FLAGS={}".format(" ".join("-l{}".format(lib) for lib in libraries)),
+            "-DCMAKE_EXE_LINKER_FLAGS={}".format(
+                " ".join("-l{}".format(lib) for lib in libraries)
+            ),
             "-DCMAKE_INSTALL_PREFIX={}".format(installDir),
             "-DCMAKE_INSTALL_LIBDIR=lib",
             "-DBENCHMARK_CXX_LIBRARIES={}".format(";".join(libraries)),
             "-DBENCHMARK_ENABLE_TESTING=OFF",
             "-DBENCHMARK_ENABLE_WERROR=OFF",

``````````

</details>


https://github.com/llvm/llvm-project/pull/225590


More information about the libcxx-commits mailing list