[libcxx-commits] [libcxx] [libc++] Address missing cmake in libcxx.test.googlebenchmark (PR #225590)

[via libcxx-commits]

zeroomega wrote:

> Can you explain where `config.cmake` is coming from? It's not usually set in the configs I am aware of.
> 
> Also, the current logic is to use the `CMAKE` env var if present, but to fall back to `cmake` in path otherwise -- I'd argue the fix here is for the runners to have `cmake` in their PATH.

I am aware this patch doesn't work and I am trying to see how to propagate cmake path from lit config right now.

I would argue your approach to read cmake from PATH or CMAKE env arg is wrong. The build should be self contained. This is the first time we see a llvm comment depends on cmake in PATH or in CMAKE.

We prefer not to place anything in the PATH as the toolchain should be built under a hermetic environment and should not implicitly depends on anything from host. In fact, when I try to reproduce the failure on my corp machine, the build uses the cmake 4.3 from our build config, but the `libcxx.test.googlebenchmark` used the cmake 3.25 from my host's apt install.  That is the exact situation we would like to avoid and using a clean PATH on our bots caught it.


https://github.com/llvm/llvm-project/pull/225590