[libcxx-commits] [libcxx] [libc++] Add missing <cstring> include in the string benchmark (PR #225501)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Sep 22 12:45:56 PDT 2026


llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

<details>
<summary>Changes</summary>

The benchmark uses std::strlen but never includes <cstring>.

---
Full diff: https://github.com/llvm/llvm-project/pull/225501.diff


1 Files Affected:

- (modified) libcxx/test/benchmarks/containers/string.bench.cpp (+1) 


``````````diff
diff --git a/libcxx/test/benchmarks/containers/string.bench.cpp b/libcxx/test/benchmarks/containers/string.bench.cpp
index b795654e84281..aaf8f69df37b4 100644
--- a/libcxx/test/benchmarks/containers/string.bench.cpp
+++ b/libcxx/test/benchmarks/containers/string.bench.cpp
@@ -10,6 +10,7 @@
 
 #include <algorithm>
 #include <array>
+#include <cstring>
 #include <functional>
 #include <string>
 #include <vector>

``````````

</details>


https://github.com/llvm/llvm-project/pull/225501


More information about the libcxx-commits mailing list