[libcxx-commits] [libcxx] [libc++] Refactor container's types.pass.cpp tests (PR #223602)

A. Jiang via libcxx-commits libcxx-commits at lists.llvm.org
Tue Sep 15 19:57:30 PDT 2026


================
@@ -0,0 +1,41 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// <queue>
+
+// template <class T, class Container = vector<T>,
+//           class Compare = less<typename Container::value_type>>
+// class priority_queue
+// {
+// public:
+//     typedef Container                                container_type;
+//     typedef Compare                                  value_compare; // LWG#2684
+//     typedef typename container_type::value_type      value_type;
+//     typedef typename container_type::reference       reference;
+//     typedef typename container_type::const_reference const_reference;
+//     typedef typename container_type::size_type       size_type;
+//
----------------
frederick-vs-ja wrote:

For this file, I think it's a bit better to trop these for clarity.
```suggestion
```

Also, it might be better to rename this file to `protected.pass.cpp`, but I'm not very sure.

Other test files LGTM!

https://github.com/llvm/llvm-project/pull/223602


More information about the libcxx-commits mailing list