[libcxx-commits] [libcxx] [libc++] Skip including langinfo.h on Android (PR #223749)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Sep 15 13:58:10 PDT 2026


enh-google wrote:

> This include was introduced in #141312. And, while the solution is nice and easy on Android, I'd note that the _problem_ impacts more than just Android -- it looks like many libc impls (other than glibc) use a bunch of un-namespaced `#defines` in their langinfo.h header. It may be best to find a way to entirely eliminate this include from (transitively-public) libc++ headers...

yeah, as far as i can see it's _only_ glibc that uses an enum here.

given that, it's probably worth changing the title of the PR, but other than that lgtm.

https://github.com/llvm/llvm-project/pull/223749


More information about the libcxx-commits mailing list