[libcxx-commits] [libcxx] [libc++] Skip including langinfo.h on Android (PR #223749)
via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Sep 15 11:09:14 PDT 2026
google-yfyang wrote:
> > __get_locale_encoding() is only used when compiling the shared library
>
> Oh, I missed that! That's great news, that makes the fix easy.
>
> > so we could move the <langinfo.h> include next to it, inside the _LIBCPP_BUILDING_LIBRARY block, although it goes against our style guides.
>
> Can just keep the include at the top of the file, protected by `#if defined(_LIBCPP_BUILDING_LIBRARY)` instead of the proposed-here `__ANDROID__`?
Okay done.
https://github.com/llvm/llvm-project/pull/223749
More information about the libcxx-commits
mailing list