[libcxx-commits] [libcxx] [libc++] added benchmarks for `string::append()` (PR #213990)

[Pavel Novikov via libcxx-commits]

================
@@ -43,6 +43,25 @@ void bench(std::string name, Func func, Mod modifier = {}) {
 #endif
 }
 
+template <typename Iterator>
----------------
toughengineer wrote:

If there are currently no places that `unoptimizable_forward_iterator` needs to be used in and there are no plans to use it in particular places, then there is no reason to put it in a header at this time.
The idea that at some unknown point in time `unoptimizable_forward_iterator` can be needed somewhere else is not a reason enough, it can be factored out into a header at that point.

It can be said about anything that at some point it may be needed in some other places, it's not a reason to immediately put it in a header.

By "tentative plans" I mean any plans, maybe not fully fleshed out, to use `unoptimizable_forward_iterator` in particular places that you or others have in mind.

Are there any plans to introduce such places that need `unoptimizable_forward_iterator` as well?

https://github.com/llvm/llvm-project/pull/213990