[libcxx-commits] [libcxx] [libc++][ranges][enumerate_view] Update sentinel `equal` test (PR #222331)

Hristo Hristov via libcxx-commits libcxx-commits at lists.llvm.org
Sat Sep 12 00:57:10 PDT 2026


Zingam wrote:

> > > But have we been testing the constraints of this operator==?
> > 
> > 
> > Still not sure... Should we reference #74655 ?
> 
> #74655 seems to be technically unrelated and I believe it's better not to reference it in the PR description. Maybe it's fine to copy the testing strategy in it.

@lknknm My initial strategy (I believe) was to keep as close to other implementations. I don't think this worked out very well. So we don't need to reference anything like that IMO. It would be best if all tests are consistent and similarly structured and use the same conventions but I don't think that's the case often.

We need to improve the coverage for operator==, operator-. There are similar cases for `elements_view`, any views from the zip category/paper like `adjacent_view`, etc.

@frederick-vs-ja Sorry. I updated your comment instead of quoting it,.. somehow!

https://github.com/llvm/llvm-project/pull/222331


More information about the libcxx-commits mailing list