[libcxx-commits] [libcxx] [libcxx] [test] Update XFAILs for a clang-cl bug fixed in clang 23 (PR #234630)

[via libcxx-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Martin Storsjö (mstorsjo)

<details>
<summary>Changes</summary>

This issue, issue https://github.com/llvm/llvm-project/issues/40363, was fixed by PR https://github.com/llvm/llvm-project/pull/168171 (commit 9ce9e4e6c19bed1781db2c20fae7f24c905438e9) for LLVM 23.

Therefore, update the XFAILs to limit the XFAIL to clang 21 and 22. (Older versions aren't supported.)

This unblocks one aspect of updating the version of clang-cl in CI to version 23.

---
Full diff: https://github.com/llvm/llvm-project/pull/234630.diff


5 Files Affected:

- (modified) libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp (+1-1) 
- (modified) libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp (+1-1) 
- (modified) libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp (+1-1) 
- (modified) libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp (+1-1) 
- (modified) libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp (+1-1) 


``````````diff
diff --git a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp
index 8ae6bc2d3ba666..79e76c201e441b 100644
--- a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp
@@ -23,7 +23,7 @@
 //     up the OS's collation files.
 
 // https://llvm.org/PR41018
-// XFAIL: windows-dll && msvc
+// XFAIL: windows-dll && msvc && (clang-21 || clang-22)
 
 #include <locale>
 #include <string>
diff --git a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
index 383b978355d434..34abc94b3f6bc7 100644
--- a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
@@ -9,7 +9,7 @@
 // REQUIRES: locale.en_US.UTF-8
 
 // https://llvm.org/PR41018
-// XFAIL: windows-dll && msvc
+// XFAIL: windows-dll && msvc && (clang-21 || clang-22)
 
 // <locale>
 
diff --git a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
index 8028b444659174..020e4ddc98b51a 100644
--- a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // https://llvm.org/PR41018
-// XFAIL: windows-dll && msvc
+// XFAIL: windows-dll && msvc && (clang-21 || clang-22)
 
 // <locale>
 
diff --git a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
index 7bcfe917f9497b..c9d954bce11af5 100644
--- a/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // https://llvm.org/PR41018
-// XFAIL: windows-dll && msvc
+// XFAIL: windows-dll && msvc && (clang-21 || clang-22)
 
 // <locale>
 
diff --git a/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp b/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
index c435f86f7e9e7e..e6488586a09f18 100644
--- a/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
+++ b/libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // https://llvm.org/PR41018
-// XFAIL: windows-dll && msvc
+// XFAIL: windows-dll && msvc && (clang-21 || clang-22)
 
 // <locale>
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/234630