[libcxx-commits] [libcxx] [libc++] Remove redundant `_LIBCPP_HIDE_FROM_ABI` from detail headers d-i (PR #234100)
via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Oct 21 00:55:20 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h -- libcxx/include/__debug_utils/randomize_range.h libcxx/include/__debug_utils/sanitizers.h libcxx/include/__debug_utils/strict_weak_ordering_check.h libcxx/include/__expected/expected.h libcxx/include/__expected/unexpected.h libcxx/include/__filesystem/copy_options.h libcxx/include/__filesystem/directory_options.h libcxx/include/__filesystem/file_status.h libcxx/include/__filesystem/operations.h libcxx/include/__filesystem/perm_options.h libcxx/include/__filesystem/perms.h libcxx/include/__filesystem/space_info.h libcxx/include/__filesystem/u8path.h libcxx/include/__flat_map/flat_map.h libcxx/include/__flat_map/flat_multimap.h libcxx/include/__flat_map/key_value_iterator.h libcxx/include/__flat_map/utils.h libcxx/include/__flat_set/flat_multiset.h libcxx/include/__flat_set/flat_set.h libcxx/include/__flat_set/ra_iterator.h libcxx/include/__flat_set/utils.h libcxx/include/__format/buffer.h libcxx/include/__format/container_adaptor.h libcxx/include/__format/escaped_output_table.h libcxx/include/__format/extended_grapheme_cluster_table.h libcxx/include/__format/format_arg.h libcxx/include/__format/format_arg_store.h libcxx/include/__format/format_args.h libcxx/include/__format/format_context.h libcxx/include/__format/format_functions.h libcxx/include/__format/format_parse_context.h libcxx/include/__format/format_string.h libcxx/include/__format/formatter.h libcxx/include/__format/formatter_bool.h libcxx/include/__format/formatter_bool_impl.h libcxx/include/__format/formatter_char.h libcxx/include/__format/formatter_floating_point.h libcxx/include/__format/formatter_integer.h libcxx/include/__format/formatter_integral.h libcxx/include/__format/formatter_output.h libcxx/include/__format/formatter_pointer.h libcxx/include/__format/formatter_string.h libcxx/include/__format/formatter_tuple.h libcxx/include/__format/indic_conjunct_break_table.h libcxx/include/__format/parser_std_format_spec.h libcxx/include/__format/range_default_formatter.h libcxx/include/__format/range_formatter.h libcxx/include/__format/unicode.h libcxx/include/__format/width_estimation_table.h libcxx/include/__format/write_escaped.h libcxx/include/__functional/binary_negate.h libcxx/include/__functional/bind.h libcxx/include/__functional/bind_back.h libcxx/include/__functional/bind_front.h libcxx/include/__functional/binder1st.h libcxx/include/__functional/binder2nd.h libcxx/include/__functional/boyer_moore_searcher.h libcxx/include/__functional/compose.h libcxx/include/__functional/default_searcher.h libcxx/include/__functional/function_ref_common.h libcxx/include/__functional/function_ref_impl.h libcxx/include/__functional/hash.h libcxx/include/__functional/identity.h libcxx/include/__functional/invoke.h libcxx/include/__functional/mem_fn.h libcxx/include/__functional/mem_fun_ref.h libcxx/include/__functional/not_fn.h libcxx/include/__functional/operations.h libcxx/include/__functional/perfect_forward.h libcxx/include/__functional/pointer_to_binary_function.h libcxx/include/__functional/pointer_to_unary_function.h libcxx/include/__functional/ranges_operations.h libcxx/include/__functional/reference_wrapper.h libcxx/include/__functional/unary_negate.h libcxx/include/__fwd/array.h libcxx/include/__fwd/bit_reference.h libcxx/include/__fwd/complex.h libcxx/include/__fwd/pair.h libcxx/include/__fwd/subrange.h libcxx/include/__fwd/tuple.h libcxx/include/__fwd/variant.h libcxx/include/__ios/fpos.h libcxx/include/__iterator/access.h libcxx/include/__iterator/advance.h libcxx/include/__iterator/aliasing_iterator.h libcxx/include/__iterator/back_insert_iterator.h libcxx/include/__iterator/bounded_iter.h libcxx/include/__iterator/capacity_aware_iterator.h libcxx/include/__iterator/common_iterator.h libcxx/include/__iterator/counted_iterator.h libcxx/include/__iterator/data.h libcxx/include/__iterator/distance.h libcxx/include/__iterator/empty.h libcxx/include/__iterator/erase_if_container.h libcxx/include/__iterator/front_insert_iterator.h libcxx/include/__iterator/insert_iterator.h libcxx/include/__iterator/istream_iterator.h libcxx/include/__iterator/istreambuf_iterator.h libcxx/include/__iterator/iter_move.h libcxx/include/__iterator/iter_swap.h libcxx/include/__iterator/iterator_with_data.h libcxx/include/__iterator/move_iterator.h libcxx/include/__iterator/move_sentinel.h libcxx/include/__iterator/next.h libcxx/include/__iterator/ostream_iterator.h libcxx/include/__iterator/ostreambuf_iterator.h libcxx/include/__iterator/prev.h libcxx/include/__iterator/reverse_access.h libcxx/include/__iterator/reverse_iterator.h libcxx/include/__iterator/size.h libcxx/include/__iterator/static_bounded_iter.h libcxx/include/__iterator/unreachable_sentinel.h libcxx/include/__iterator/wrap_iter.h --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/libcxx/include/__flat_map/flat_map.h b/libcxx/include/__flat_map/flat_map.h
index 46878146d..4cb6b65ab 100644
--- a/libcxx/include/__flat_map/flat_map.h
+++ b/libcxx/include/__flat_map/flat_map.h
@@ -459,7 +459,7 @@ public:
template <class _Kp>
requires(__is_compare_transparent && is_constructible_v<key_type, _Kp> && is_constructible_v<mapped_type> &&
- !is_convertible_v<_Kp &&, const_iterator> && !is_convertible_v<_Kp &&, iterator>)
+ !is_convertible_v<_Kp&&, const_iterator> && !is_convertible_v<_Kp&&, iterator>)
_LIBCPP_CONSTEXPR_SINCE_CXX26 mapped_type& operator[](_Kp&& __x) {
return try_emplace(std::forward<_Kp>(__x)).first->second;
}
@@ -614,8 +614,8 @@ public:
template <class _Kp, class... _Args>
requires(__is_compare_transparent && is_constructible_v<key_type, _Kp> &&
- is_constructible_v<mapped_type, _Args...> && !is_convertible_v<_Kp &&, const_iterator> &&
- !is_convertible_v<_Kp &&, iterator>)
+ is_constructible_v<mapped_type, _Args...> && !is_convertible_v<_Kp&&, const_iterator> &&
+ !is_convertible_v<_Kp&&, iterator>)
_LIBCPP_CONSTEXPR_SINCE_CXX26 pair<iterator, bool> try_emplace(_Kp&& __key, _Args&&... __args) {
return __try_emplace(std::forward<_Kp>(__key), std::forward<_Args>(__args)...);
}
@@ -695,8 +695,7 @@ public:
}
template <class _Kp>
- requires(__is_compare_transparent && !is_convertible_v<_Kp &&, iterator> &&
- !is_convertible_v<_Kp &&, const_iterator>)
+ requires(__is_compare_transparent && !is_convertible_v<_Kp&&, iterator> && !is_convertible_v<_Kp&&, const_iterator>)
_LIBCPP_CONSTEXPR_SINCE_CXX26 size_type erase(_Kp&& __x) {
auto [__first, __last] = equal_range(__x);
auto __res = __last - __first;
diff --git a/libcxx/include/__flat_map/flat_multimap.h b/libcxx/include/__flat_map/flat_multimap.h
index 7bd4a66bd..1f5720c28 100644
--- a/libcxx/include/__flat_map/flat_multimap.h
+++ b/libcxx/include/__flat_map/flat_multimap.h
@@ -597,8 +597,7 @@ public:
}
template <class _Kp>
- requires(__is_compare_transparent && !is_convertible_v<_Kp &&, iterator> &&
- !is_convertible_v<_Kp &&, const_iterator>)
+ requires(__is_compare_transparent && !is_convertible_v<_Kp&&, iterator> && !is_convertible_v<_Kp&&, const_iterator>)
_LIBCPP_CONSTEXPR_SINCE_CXX26 size_type erase(_Kp&& __x) {
auto [__first, __last] = equal_range(__x);
auto __res = __last - __first;
diff --git a/libcxx/include/__flat_set/flat_multiset.h b/libcxx/include/__flat_set/flat_multiset.h
index b282e7fa2..a6ca79307 100644
--- a/libcxx/include/__flat_set/flat_multiset.h
+++ b/libcxx/include/__flat_set/flat_multiset.h
@@ -465,8 +465,8 @@ public:
}
template <class _Kp>
- requires(__is_transparent_v<_Compare> && !is_convertible_v<_Kp &&, iterator> &&
- !is_convertible_v<_Kp &&, const_iterator>)
+ requires(__is_transparent_v<_Compare> && !is_convertible_v<_Kp&&, iterator> &&
+ !is_convertible_v<_Kp&&, const_iterator>)
_LIBCPP_CONSTEXPR_SINCE_CXX26 size_type erase(_Kp&& __x) {
auto [__first, __last] = equal_range(__x);
auto __res = __last - __first;
diff --git a/libcxx/include/__flat_set/flat_set.h b/libcxx/include/__flat_set/flat_set.h
index 59badd2e6..b5dd5687f 100644
--- a/libcxx/include/__flat_set/flat_set.h
+++ b/libcxx/include/__flat_set/flat_set.h
@@ -485,8 +485,8 @@ public:
}
template <class _Kp>
- requires(__is_transparent_v<_Compare> && !is_convertible_v<_Kp &&, iterator> &&
- !is_convertible_v<_Kp &&, const_iterator>)
+ requires(__is_transparent_v<_Compare> && !is_convertible_v<_Kp&&, iterator> &&
+ !is_convertible_v<_Kp&&, const_iterator>)
_LIBCPP_CONSTEXPR_SINCE_CXX26 size_type erase(_Kp&& __x) {
auto [__first, __last] = equal_range(__x);
auto __res = __last - __first;
diff --git a/libcxx/include/__functional/function_ref_impl.h b/libcxx/include/__functional/function_ref_impl.h
index 154d297ff..6bbd918c6 100644
--- a/libcxx/include/__functional/function_ref_impl.h
+++ b/libcxx/include/__functional/function_ref_impl.h
@@ -145,7 +145,7 @@ public:
}
template <auto _Cw, class _Fn, class _Up, class _Tp = remove_reference_t<_Up>>
- requires(!is_rvalue_reference_v<_Up &&>) && __is_invocable_using<const _Fn&, _LIBCPP_FUNCTION_REF_CV _Tp&>
+ requires(!is_rvalue_reference_v<_Up&&>) && __is_invocable_using<const _Fn&, _LIBCPP_FUNCTION_REF_CV _Tp&>
constexpr function_ref(constant_wrapper<_Cw, _Fn> __f, _Up&& __obj) noexcept
: __storage_(std::addressof(__obj)),
__call_([](__storage_t __storage, __arg_t<_ArgTypes>... __args) static noexcept(__is_noexcept) -> _Rp {
diff --git a/libcxx/include/__iterator/iter_move.h b/libcxx/include/__iterator/iter_move.h
index 1b0eb7981..e0fed9b44 100644
--- a/libcxx/include/__iterator/iter_move.h
+++ b/libcxx/include/__iterator/iter_move.h
@@ -53,7 +53,7 @@ concept __move_deref = !__unqualified_iter_move<_Tp> && requires(_Tp&& __t) {
template <class _Tp>
concept __just_deref = !__unqualified_iter_move<_Tp> && !__move_deref<_Tp> && requires(_Tp&& __t) {
*__t;
- requires(!is_lvalue_reference_v<decltype(* __t)>);
+ requires(!is_lvalue_reference_v<decltype(*__t)>);
};
// [iterator.cust.move]
``````````
</details>
https://github.com/llvm/llvm-project/pull/234100
More information about the libcxx-commits
mailing list