[libcxx-commits] [libcxx] [NFC][libc++][string] Improve constexpr efficiency (PR #184724)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> Sorry, you are correct, I will not argue about this.

I'm happy we can agree!

> Just here it seems very straightforward (to my taste).

Yes, it's not super complex. The issue is that IMO it also adds very little. I don't think constexpr steps is much of a meaningful metric, because AFAICT it doesn't correlate much with metrics people really care about (e.g. compile time or run time). The only issue this solves is that users have to pass a flag at a tiny bit later point, which I don't think we should increase complexity for. If you could show that this significantly improves compile time I think we'd be much more open to this.

https://github.com/llvm/llvm-project/pull/184724