[libcxx-commits] [libcxx] [llvm] [libcxx][CMake] Rework LLVM_ENABLE_ASSERTIONS interaction w. libcxx hardening (PR #229359)

[Steven Wu via libcxx-commits]

https://github.com/cachemeifyoucan requested changes to this pull request.

I am not a fan for this change, because:
* LLVM_ENABLE_ASSERTION is a global debugging switch. It makes sense to build libcxx binary with extensive mode when configured together.
* If different configuration between LLVM and libcxx is needed, you can always configure them separately. 
* LIBCXX_SUPPORTED_HARDENING_MODES is still being used to configure both header and runtime. There is no separation except in one narrow case. 

I think if you either support complete separate configuration between libcxx and llvm, or just lock them and ask user to configure them separately. This patch is trying to do something in between and only adds confusion.

https://github.com/llvm/llvm-project/pull/229359