[libcxx-commits] [libcxx] [llvm] [libcxx][CMake] Rework LLVM_ENABLE_ASSERTIONS interaction w. libcxx hardening (PR #229359)

[Mészáros Gergely via libcxx-commits]

Maetveis wrote:

> we set the default hardening mode of libcxx itself when performing an assertions build. This is in theory orthogonal to the hardening of binaries and tests. It enables runtime hardening checks not in the compiler itself, but in the code that links against libcxx (e.g. applications compiled using the toolchain we just built).

This behavior was introduced in https://github.com/llvm/llvm-project/pull/68541, due to https://github.com/llvm/llvm-project/pull/182383 I have the feeling that it might have been by mistake, and its actually not desired. In that case I can just as well remove it instead of reworking it.

https://github.com/llvm/llvm-project/pull/229359