[libcxx-commits] [libcxx] [libc++] Suppress unsigned-integer-overflow warning in <charconv> (PR #225801)
via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Oct 5 00:17:57 PDT 2026
hchataing wrote:
> > > As requested in [#225801 (comment)](https://github.com/llvm/llvm-project/pull/225801#discussion_r4145302714), we'd rather not reformat unrelated test code, so I undid the formatting-only changes to make the PR's diff reviewable.
> >
> >
> > That was the output of `git clang-format` ..
>
> That's fine, but what I am saying is that it makes the PR unreviewable, so we'd rather land it with a red formatting job than make the PR unreviewable. That's what we do for changes in the test suite since we have not reformatted our whole test suite yet.
I have nothing to add on my side then :+1:
https://github.com/llvm/llvm-project/pull/225801
More information about the libcxx-commits
mailing list