[libcxx-commits] [libcxx] [libc++][test] Remove some `XFAIL` for LLVM libc in multi-threaded tests (PR #228036)

[via libcxx-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: A. Jiang (frederick-vs-ja)

<details>
<summary>Changes</summary>

Recently, LLVM libc fixed https://llvm.org/PR194029 in https://llvm.org/PR226134, so more libc++ tests passes with LLVM libc now.

---
Full diff: https://github.com/llvm/llvm-project/pull/228036.diff


3 Files Affected:

- (modified) libcxx/test/libcxx/thread/thread.condition/PR30202_notify_from_pthread_created_thread.pass.cpp (-3) 
- (modified) libcxx/test/std/input.output/syncstream/osyncstream/thread/several_threads.pass.cpp (-3) 
- (modified) libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp (-3) 


``````````diff
diff --git a/libcxx/test/libcxx/thread/thread.condition/PR30202_notify_from_pthread_created_thread.pass.cpp b/libcxx/test/libcxx/thread/thread.condition/PR30202_notify_from_pthread_created_thread.pass.cpp
index 1df75885e4347..d840e3644149e 100644
--- a/libcxx/test/libcxx/thread/thread.condition/PR30202_notify_from_pthread_created_thread.pass.cpp
+++ b/libcxx/test/libcxx/thread/thread.condition/PR30202_notify_from_pthread_created_thread.pass.cpp
@@ -20,9 +20,6 @@
 // Test that this function works with threads that were not created by
 // std::thread. See https://llvm.org/PR30202
 
-// Segfault
-// XFAIL: LLVM-LIBC-FIXME
-
 #include <condition_variable>
 #include <mutex>
 #include <thread>
diff --git a/libcxx/test/std/input.output/syncstream/osyncstream/thread/several_threads.pass.cpp b/libcxx/test/std/input.output/syncstream/osyncstream/thread/several_threads.pass.cpp
index 82d43c1673d2d..dbf2ded1b532e 100644
--- a/libcxx/test/std/input.output/syncstream/osyncstream/thread/several_threads.pass.cpp
+++ b/libcxx/test/std/input.output/syncstream/osyncstream/thread/several_threads.pass.cpp
@@ -21,9 +21,6 @@
 // but the words should be written without interleaving. To increment the
 // change of interleaving words are written one character at a time.
 
-// segmentation fault
-// XFAIL: LLVM-LIBC-FIXME
-
 #include <cassert>
 #include <chrono>
 #include <mutex>
diff --git a/libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp b/libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp
index f1b349017b1a5..61094eced4cb2 100644
--- a/libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp
+++ b/libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp
@@ -23,9 +23,6 @@
 //
 // void notify_all_at_thread_exit(condition_variable& cond, unique_lock<mutex> lk);
 
-// segmentation fault
-// XFAIL: LLVM-LIBC-FIXME
-
 #include "make_test_thread.h"
 #include "test_macros.h"
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/228036