[libcxx-commits] [libcxx] 4def779 - [libc++][NFC] Remove lit annotations for older AppleClang versions (#199817)

via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 27 02:06:30 PDT 2026


Author: Nikolas Klauser
Date: 2026-05-27T11:06:24+02:00
New Revision: 4def779282d9c2a179fcfeb0079928f1bb2ce409

URL: https://github.com/llvm/llvm-project/commit/4def779282d9c2a179fcfeb0079928f1bb2ce409
DIFF: https://github.com/llvm/llvm-project/commit/4def779282d9c2a179fcfeb0079928f1bb2ce409.diff

LOG: [libc++][NFC] Remove lit annotations for older AppleClang versions (#199817)

We don't support anything older than apple-clang-21, so we can remove
those annotations.

Added: 
    

Modified: 
    libcxx/test/libcxx-03/vendor/apple/disable-availability.sh.cpp
    libcxx/test/libcxx/utilities/meta/is_within_lifetime.verify.cpp
    libcxx/test/selftest/modules/std-and-std.compat-module.sh.cpp
    libcxx/test/selftest/modules/std-module.sh.cpp
    libcxx/test/selftest/modules/std.compat-module.sh.cpp
    libcxx/test/std/modules/std.compat.pass.cpp
    libcxx/test/std/modules/std.pass.cpp
    libcxx/test/std/numerics/c.math/signbit.pass.cpp
    libcxx/test/std/utilities/meta/meta.const.eval/is_within_lifetime.compile.pass.cpp
    libcxx/test/std/utilities/meta/meta.rel/is_virtual_base_of.pass.cpp
    libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp
    libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx-03/vendor/apple/disable-availability.sh.cpp b/libcxx/test/libcxx-03/vendor/apple/disable-availability.sh.cpp
index f44b49b1ddfba..b09a0b7e45ca6 100644
--- a/libcxx/test/libcxx-03/vendor/apple/disable-availability.sh.cpp
+++ b/libcxx/test/libcxx-03/vendor/apple/disable-availability.sh.cpp
@@ -8,10 +8,6 @@
 
 // REQUIRES: stdlib=apple-libc++
 
-// This test is dependent on the code generated by the compiler, and it doesn't
-// work properly with older AppleClangs.
-// UNSUPPORTED: apple-clang-15
-
 // This test ensures that we retain a way to disable availability markup on Apple platforms
 // in order to work around Clang bug https://llvm.org/PR134151.
 //

diff  --git a/libcxx/test/libcxx/utilities/meta/is_within_lifetime.verify.cpp b/libcxx/test/libcxx/utilities/meta/is_within_lifetime.verify.cpp
index ff3ecfbbc120c..0aa0f226d63ca 100644
--- a/libcxx/test/libcxx/utilities/meta/is_within_lifetime.verify.cpp
+++ b/libcxx/test/libcxx/utilities/meta/is_within_lifetime.verify.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20, c++23
-// UNSUPPORTED: gcc-15, apple-clang-17
+// UNSUPPORTED: gcc-15
 
 // <type_traits>
 

diff  --git a/libcxx/test/selftest/modules/std-and-std.compat-module.sh.cpp b/libcxx/test/selftest/modules/std-and-std.compat-module.sh.cpp
index 32e4c06f750c5..0d514ed777fa9 100644
--- a/libcxx/test/selftest/modules/std-and-std.compat-module.sh.cpp
+++ b/libcxx/test/selftest/modules/std-and-std.compat-module.sh.cpp
@@ -15,9 +15,6 @@
 
 // XFAIL: has-no-cxx-module-support
 
-// Apple Clang 17 advertises C++ Modules support but fails to compile this test.
-// XFAIL: apple-clang-17
-
 // C++20 modules are incompatible with Clang modules
 // ADDITIONAL_COMPILE_FLAGS: -fno-modules
 

diff  --git a/libcxx/test/selftest/modules/std-module.sh.cpp b/libcxx/test/selftest/modules/std-module.sh.cpp
index 8304d5f429190..667188876e4d7 100644
--- a/libcxx/test/selftest/modules/std-module.sh.cpp
+++ b/libcxx/test/selftest/modules/std-module.sh.cpp
@@ -15,9 +15,6 @@
 
 // XFAIL: has-no-cxx-module-support
 
-// Apple Clang 17 advertises C++ Modules support but fails to compile this test.
-// XFAIL: apple-clang-17
-
 // C++20 modules are incompatible with Clang modules
 // ADDITIONAL_COMPILE_FLAGS: -fno-modules
 

diff  --git a/libcxx/test/selftest/modules/std.compat-module.sh.cpp b/libcxx/test/selftest/modules/std.compat-module.sh.cpp
index cdfd1a187fbff..8bce59b99279b 100644
--- a/libcxx/test/selftest/modules/std.compat-module.sh.cpp
+++ b/libcxx/test/selftest/modules/std.compat-module.sh.cpp
@@ -15,9 +15,6 @@
 
 // XFAIL: has-no-cxx-module-support
 
-// Apple Clang 17 advertises C++ Modules support but fails to compile this test.
-// XFAIL: apple-clang-17
-
 // C++20 modules are incompatible with Clang modules
 // ADDITIONAL_COMPILE_FLAGS: -fno-modules
 

diff  --git a/libcxx/test/std/modules/std.compat.pass.cpp b/libcxx/test/std/modules/std.compat.pass.cpp
index a99f34b4ed19f..0d1a4ac7d89c4 100644
--- a/libcxx/test/std/modules/std.compat.pass.cpp
+++ b/libcxx/test/std/modules/std.compat.pass.cpp
@@ -11,9 +11,6 @@
 
 // XFAIL: has-no-cxx-module-support
 
-// Apple Clang 17 advertises C++ Modules support but fails to compile this test.
-// XFAIL: apple-clang-17
-
 // A minimal test to validate import works.
 
 // C++20 modules are incompatible with Clang modules

diff  --git a/libcxx/test/std/modules/std.pass.cpp b/libcxx/test/std/modules/std.pass.cpp
index 325a2fdebe1bc..4587dcb1b8178 100644
--- a/libcxx/test/std/modules/std.pass.cpp
+++ b/libcxx/test/std/modules/std.pass.cpp
@@ -11,9 +11,6 @@
 
 // XFAIL: has-no-cxx-module-support
 
-// Apple Clang 17 advertises C++ Modules support but fails to compile this test.
-// XFAIL: apple-clang-17
-
 // A minimal test to validate import works.
 
 // C++20 modules are incompatible with Clang modules

diff  --git a/libcxx/test/std/numerics/c.math/signbit.pass.cpp b/libcxx/test/std/numerics/c.math/signbit.pass.cpp
index 5655370e60bb0..ce219b3a35c0b 100644
--- a/libcxx/test/std/numerics/c.math/signbit.pass.cpp
+++ b/libcxx/test/std/numerics/c.math/signbit.pass.cpp
@@ -11,9 +11,6 @@
 // We don't control the implementation on windows
 // UNSUPPORTED: windows
 
-// These compilers don't support constexpr `__builtin_signbit` yet.
-// UNSUPPORTED: apple-clang-17
-
 // GCC warns about signbit comparing `bool_v < 0`, which we're testing
 // ADDITIONAL_COMPILE_FLAGS(gcc): -Wno-bool-compare
 

diff  --git a/libcxx/test/std/utilities/meta/meta.const.eval/is_within_lifetime.compile.pass.cpp b/libcxx/test/std/utilities/meta/meta.const.eval/is_within_lifetime.compile.pass.cpp
index 40c2273f1f862..dee05dfa7e4bd 100644
--- a/libcxx/test/std/utilities/meta/meta.const.eval/is_within_lifetime.compile.pass.cpp
+++ b/libcxx/test/std/utilities/meta/meta.const.eval/is_within_lifetime.compile.pass.cpp
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20, c++23
-// UNSUPPORTED: gcc-15, apple-clang-17
+// UNSUPPORTED: gcc-15
 
 // <type_traits>
 

diff  --git a/libcxx/test/std/utilities/meta/meta.rel/is_virtual_base_of.pass.cpp b/libcxx/test/std/utilities/meta/meta.rel/is_virtual_base_of.pass.cpp
index b6b226c7f79d8..094fd7cbdfa4e 100644
--- a/libcxx/test/std/utilities/meta/meta.rel/is_virtual_base_of.pass.cpp
+++ b/libcxx/test/std/utilities/meta/meta.rel/is_virtual_base_of.pass.cpp
@@ -8,9 +8,6 @@
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20, c++23
 
-// These compilers don't support __builtin_is_virtual_base_of yet.
-// UNSUPPORTED: apple-clang-17
-
 // <type_traits>
 
 // std::is_virtual_base_of

diff  --git a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp
index 56ac03ad69b8e..de91069713068 100644
--- a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp
+++ b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp
@@ -9,7 +9,7 @@
 // REQUIRES: std-at-least-c++23
 
 // These compilers don't support __builtin_is_implicit_lifetime yet.
-// UNSUPPORTED: gcc-15, apple-clang-17
+// UNSUPPORTED: gcc-15
 
 // <type_traits>
 

diff  --git a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp
index f43693c08bc39..50144ce1b6a99 100644
--- a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp
+++ b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp
@@ -8,9 +8,6 @@
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
 
-// These compilers don't support __builtin_is_implicit_lifetime yet.
-// UNSUPPORTED: apple-clang-17
-
 // <type_traits>
 
 // template<class T> struct is_implicit_lifetime;


        


More information about the libcxx-commits mailing list