[libcxx-commits] [libcxx] [libcxx] Enrich message for std::bad_variant_access exception (PR #196495)

Hristo Hristov via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 9 00:09:23 PDT 2026


================
@@ -0,0 +1,92 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++03, c++11, c++14, no-exceptions
----------------
Zingam wrote:

```suggestion
// REQUIRES: std-at-least-c++17
// UNSUPPORTED: no-exceptions
```

Why should be this in a new file? Why didn't you update this: https://github.com/llvm/llvm-project/blob/main/libcxx/test/std/utilities/variant/variant.bad_variant_access/bad_variant_access.pass.cpp

This seems to split testing `what()` in two files which is not what we usually do. Alternatively we should have one test file per function (this file should be renamed to what.pass.cpp).

https://github.com/llvm/llvm-project/pull/196495


More information about the libcxx-commits mailing list