[libcxx-commits] [libcxx] [libc++][NFC] Remove unused #define (PR #195831)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 5 04:03:15 PDT 2026


https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/195831

We've removed the use of `_LIBCPP_ABI_BAD_FUNCTION_CALL_GOOD_WHAT_MESSAGE` a while ago, but didn't remove the `#define` for it.


>From 68c2d26fac0a3481a714f17671fb01c174b54eec Mon Sep 17 00:00:00 2001
From: Nikolas Klauser <nikolasklauser at berlin.de>
Date: Tue, 5 May 2026 13:02:12 +0200
Subject: [PATCH] [libc++][NFC] Remove unused #define

---
 libcxx/include/__configuration/abi.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/libcxx/include/__configuration/abi.h b/libcxx/include/__configuration/abi.h
index 5ce040fbcb599..8781cb11e22ef 100644
--- a/libcxx/include/__configuration/abi.h
+++ b/libcxx/include/__configuration/abi.h
@@ -52,12 +52,6 @@
 #if _LIBCPP_ABI_VERSION >= 2
 // TODO: Move the description of the remaining ABI flags to ABIGuarantees.rst or remove them.
 
-// Override the default return value of exception::what() for bad_function_call::what()
-// with a string that is specific to bad_function_call (see http://wg21.link/LWG2233).
-// This is an ABI break on platforms that sign and authenticate vtable function pointers
-// because it changes the mangling of the virtual function located in the vtable, which
-// changes how it gets signed.
-#  define _LIBCPP_ABI_BAD_FUNCTION_CALL_GOOD_WHAT_MESSAGE
 // According to the Standard, `bitset::operator[] const` returns bool
 #  define _LIBCPP_ABI_BITSET_VECTOR_BOOL_CONST_SUBSCRIPT_RETURN_BOOL
 



More information about the libcxx-commits mailing list