[libcxx-commits] [libcxx] [libcxx][string] Test: fix copy&paste typo for safe_allocator (PR #195820)

Nikita Belenkiy via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 5 03:09:01 PDT 2026


https://github.com/kitsnet created https://github.com/llvm/llvm-project/pull/195820

In test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.pass.cpp

Was missing the test for safe_allocator (test for min_allocator was called twice) safe_allocator would be consistent with the rest of that PR.

>From 194bf202198fe920470b02dddec7e37ff3737da2 Mon Sep 17 00:00:00 2001
From: Nikita Belenkiy <nikita.nb.belenkiy at partner.bmw.de>
Date: Tue, 5 May 2026 11:41:58 +0200
Subject: [PATCH] [libcxx][string] Test: fix copy&paste typo for safe_allocator

In test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.pass.cpp

Was missing the test for safe_allocator (test for min_allocator was called twice)
safe_allocator would be consistent with the rest of that PR.
---
 .../string.modifiers/string_insert/iter_iter_iter.pass.cpp      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.pass.cpp b/libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.pass.cpp
index e228ccac20574..a3cc8742c7dc3 100644
--- a/libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.pass.cpp
+++ b/libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.pass.cpp
@@ -150,7 +150,7 @@ TEST_CONSTEXPR_CXX20 bool test() {
   test_string<std::string>();
 #if TEST_STD_VER >= 11
   test_string<std::basic_string<char, std::char_traits<char>, min_allocator<char>>>();
-  test_string<std::basic_string<char, std::char_traits<char>, min_allocator<char>>>();
+  test_string<std::basic_string<char, std::char_traits<char>, safe_allocator<char>>>();
 #endif
 
 #ifndef TEST_HAS_NO_EXCEPTIONS



More information about the libcxx-commits mailing list