[libcxx-commits] [libcxx] [libc++][test] Unblock cases for `ranges::sort` with proxy ranges (PR #188490)

A. Jiang via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 25 06:59:38 PDT 2026


https://github.com/frederick-vs-ja created https://github.com/llvm/llvm-project/pull/188490

libc++ switched to use `iter_move`/`iter_swap` long time ago, so we should unblock these cases.

>From 7796c8febdcb59eb9c6b41cf625b8bf4989e4b67 Mon Sep 17 00:00:00 2001
From: "A. Jiang" <de34 at live.cn>
Date: Wed, 25 Mar 2026 21:56:50 +0800
Subject: [PATCH] [libc++][test] Unblock cases for `ranges::sort` with proxy
 ranges

libc++ switched to use `iter_move`/`iter_swap` long time ago, so we
should unblock these cases.
---
 .../algorithms/alg.sorting/alg.sort/sort/ranges.sort.pass.cpp  | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/ranges.sort.pass.cpp b/libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/ranges.sort.pass.cpp
index f9759bd887775..68a1071bb993d 100644
--- a/libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/ranges.sort.pass.cpp
+++ b/libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/ranges.sort.pass.cpp
@@ -188,8 +188,6 @@ constexpr bool test() {
     [[maybe_unused]] std::same_as<std::ranges::dangling> decltype(auto) result = std::ranges::sort(std::array{1, 2, 3});
   }
 
-  // TODO: Enable the tests once the implementation switched to use iter_move/iter_swap
-  /*
   { // ProxyIterator
     {
       std::array in = {2, 1, 3};
@@ -206,7 +204,6 @@ constexpr bool test() {
       assert((in == std::array{1, 2, 3}));
     }
   }
-  */
 
   return true;
 }



More information about the libcxx-commits mailing list