[libcxx-commits] [libcxx] [libc++] Use __ugly__ spellings of vendor attributes in verbose_abort.cpp (PR #188396)

Fady Farag via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 24 19:05:09 PDT 2026


https://github.com/iidmsa created https://github.com/llvm/llvm-project/pull/188396

Non-standard attributes should use the _Ugly spelling as per the coding guidelines.

>From c47de2a6a0cf0bb8e6b07ac6123859aab6d5ba6a Mon Sep 17 00:00:00 2001
From: Fady Farag <com.webkit.iidmsa at gmail.com>
Date: Tue, 24 Mar 2026 21:02:18 -0500
Subject: [PATCH] [libc++] Use __ugly__ spellings of vendor attributes in
 verbose_abort.cpp

 Non-standard attributes should use the _Ugly spelling as per the coding guidelines.
---
 libcxx/src/verbose_abort.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcxx/src/verbose_abort.cpp b/libcxx/src/verbose_abort.cpp
index afe20c3cd0b16..3a8f045053595 100644
--- a/libcxx/src/verbose_abort.cpp
+++ b/libcxx/src/verbose_abort.cpp
@@ -23,7 +23,7 @@ extern "C" void android_set_abort_message(const char* msg);
 
 _LIBCPP_BEGIN_NAMESPACE_STD
 
-[[gnu::weak]] void __libcpp_verbose_abort(char const* format, ...) noexcept {
+[[__gnu__::__weak__]] void __libcpp_verbose_abort(char const* format, ...) noexcept {
   // Write message to stderr. We do this before formatting into a
   // buffer so that we still get some information out if that fails.
   {



More information about the libcxx-commits mailing list