[libcxx-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [MLIR][CMake] CMAKE_UNITY_BUILD support (PR #187414)

via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 23 09:46:22 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions c,cpp -- clang-tools-extra/clangd/support/Threading.cpp clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp clang/tools/libclang/CIndexer.cpp clang/tools/offload-arch/AMDGPUArchByHIP.cpp compiler-rt/lib/fuzzer/FuzzerExtraCountersWindows.cpp compiler-rt/lib/fuzzer/FuzzerIOWindows.cpp compiler-rt/lib/fuzzer/FuzzerUtilWindows.cpp compiler-rt/lib/interception/interception_win.cpp compiler-rt/lib/sanitizer_common/sanitizer_unwind_win.cpp compiler-rt/lib/sanitizer_common/sanitizer_win.cpp compiler-rt/lib/stats/stats_client.cpp compiler-rt/test/asan/TestCases/Windows/aligned_mallocs.cpp compiler-rt/test/asan/TestCases/Windows/beginthreadex.cpp compiler-rt/test/asan/TestCases/Windows/bind_io_completion_callback.cpp compiler-rt/test/asan/TestCases/Windows/bitfield.cpp compiler-rt/test/asan/TestCases/Windows/bitfield_uaf.cpp compiler-rt/test/asan/TestCases/Windows/crash_read_write.cpp compiler-rt/test/asan/TestCases/Windows/dll_heap_allocation.cpp compiler-rt/test/asan/TestCases/Windows/dll_host.cpp compiler-rt/test/asan/TestCases/Windows/dll_report_globals_symbolization_at_startup.cpp compiler-rt/test/asan/TestCases/Windows/dll_thread_stack_array_left_oob.cpp compiler-rt/test/asan/TestCases/Windows/dll_unload.cpp compiler-rt/test/asan/TestCases/Windows/global_const_string.cpp compiler-rt/test/asan/TestCases/Windows/global_const_string_oob.cpp compiler-rt/test/asan/TestCases/Windows/heapalloc.cpp compiler-rt/test/asan/TestCases/Windows/heapalloc_dll_double_free.cpp compiler-rt/test/asan/TestCases/Windows/heapalloc_dll_unload_realloc_uaf.cpp compiler-rt/test/asan/TestCases/Windows/heapalloc_doublefree.cpp compiler-rt/test/asan/TestCases/Windows/heapalloc_flags_fallback.cpp compiler-rt/test/asan/TestCases/Windows/heapalloc_huge.cpp compiler-rt/test/asan/TestCases/Windows/heapalloc_rtl_transfer.cpp compiler-rt/test/asan/TestCases/Windows/heapalloc_sanity.cpp compiler-rt/test/asan/TestCases/Windows/heapalloc_transfer.cpp compiler-rt/test/asan/TestCases/Windows/heapalloc_uaf.cpp compiler-rt/test/asan/TestCases/Windows/heapalloc_zero_size.cpp compiler-rt/test/asan/TestCases/Windows/heaprealloc.cpp compiler-rt/test/asan/TestCases/Windows/heaprealloc_alloc_zero.cpp compiler-rt/test/asan/TestCases/Windows/msvc/dll_control_c.cpp compiler-rt/test/asan/TestCases/Windows/msvc/dll_seh.cpp compiler-rt/test/asan/TestCases/Windows/msvc/seh.cpp compiler-rt/test/asan/TestCases/Windows/msvc/tls_init.cpp compiler-rt/test/asan/TestCases/Windows/operator_array_new_right_oob.cpp compiler-rt/test/asan/TestCases/Windows/operator_array_new_uaf.cpp compiler-rt/test/asan/TestCases/Windows/operator_delete_wrong_argument.cpp compiler-rt/test/asan/TestCases/Windows/operator_new_left_oob.cpp compiler-rt/test/asan/TestCases/Windows/operator_new_right_oob.cpp compiler-rt/test/asan/TestCases/Windows/operator_new_uaf.cpp compiler-rt/test/asan/TestCases/Windows/queue_user_work_item.cpp compiler-rt/test/asan/TestCases/Windows/queue_user_work_item_report.cpp compiler-rt/test/asan/TestCases/Windows/recalloc_sanity.cpp compiler-rt/test/asan/TestCases/Windows/report_after_syminitialize.cpp compiler-rt/test/asan/TestCases/Windows/report_globals_reload_dll.cpp compiler-rt/test/asan/TestCases/Windows/report_globals_vs_freelibrary.cpp compiler-rt/test/asan/TestCases/Windows/rtlallocateheap.cpp compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_double_free.cpp compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_dll_unload_realloc.cpp compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_flags_fallback.cpp compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_realloc_in_place.cpp compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_zero.cpp compiler-rt/test/asan/TestCases/Windows/rtlsizeheap_zero.cpp compiler-rt/test/asan/TestCases/Windows/thread_simple.cpp compiler-rt/test/asan/TestCases/Windows/thread_stack_array_left_oob.cpp compiler-rt/test/asan/TestCases/Windows/thread_stack_array_right_oob.cpp compiler-rt/test/asan/TestCases/Windows/thread_stack_reuse.cpp compiler-rt/test/asan/TestCases/Windows/thread_stress.cpp compiler-rt/test/asan/TestCases/Windows/thread_suspended.cpp compiler-rt/test/asan/TestCases/Windows/user-exception.cpp compiler-rt/test/asan/TestCases/Windows/windows_h.cpp compiler-rt/test/asan/TestCases/exitcode.cpp compiler-rt/test/asan/TestCases/ill.cpp compiler-rt/test/sanitizer_common/TestCases/Windows/dump_registers_aarch64.cpp compiler-rt/test/sanitizer_common/TestCases/Windows/dump_registers_i386.cpp compiler-rt/test/sanitizer_common/TestCases/Windows/dump_registers_x86_64.cpp flang-rt/lib/runtime/trampoline.cpp libcxx/test/libcxx-03/diagnostics/system_error_win_codes.pass.cpp libcxx/test/libcxx/diagnostics/syserr/system_error_win_codes.pass.cpp libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp libcxxabi/src/cxa_personality.cpp lldb/source/Host/common/MemoryMonitor.cpp lldb/source/Utility/Status.cpp lldb/test/API/python_api/signals/main.cpp lldb/unittests/Utility/StatusTest.cpp llvm/lib/ExecutionEngine/Orc/MemoryMapper.cpp llvm/lib/IR/DebugInfo.cpp llvm/lib/IR/Instructions.cpp llvm/lib/Support/Atomic.cpp llvm/lib/Support/CrashRecoveryContext.cpp llvm/lib/Support/HTTP/HTTPClient.cpp llvm/lib/Support/LockFileManager.cpp llvm/lib/Support/regexec.c llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp llvm/lib/Transforms/Vectorize/SandboxVectorizer/Passes/TransactionSave.cpp llvm/lib/Transforms/Vectorize/SandboxVectorizer/SandboxVectorizer.cpp llvm/tools/llvm-rc/ResourceScriptParser.cpp llvm/tools/llvm-reduce/llvm-reduce.cpp llvm/unittests/Support/CommandLineInit/CommandLineInitTest.cpp llvm/unittests/Support/CrashRecoveryTest.cpp llvm/unittests/Support/JobserverTest.cpp llvm/unittests/Support/MemoryBufferTest.cpp llvm/unittests/Support/Path.cpp llvm/unittests/Support/ProcessTest.cpp llvm/unittests/Support/ProgramTest.cpp llvm/unittests/Support/TimerTest.cpp llvm/utils/KillTheDoctor/KillTheDoctor.cpp llvm/utils/not/not.cpp mlir/lib/Dialect/Affine/Transforms/DecomposeAffineOps.cpp mlir/lib/Dialect/SparseTensor/IR/Detail/DimLvlMapParser.cpp mlir/lib/Dialect/SparseTensor/IR/Detail/LvlTypeParser.cpp mlir/lib/Dialect/SparseTensor/Transforms/Utils/SparseTensorIterator.cpp openmp/runtime/src/kmp_environment.cpp openmp/runtime/src/kmp_i18n.cpp openmp/runtime/src/kmp_io.cpp openmp/runtime/src/kmp_stub.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/compiler-rt/lib/interception/interception_win.cpp b/compiler-rt/lib/interception/interception_win.cpp
index 32b19770d..1be5c5601 100644
--- a/compiler-rt/lib/interception/interception_win.cpp
+++ b/compiler-rt/lib/interception/interception_win.cpp
@@ -129,9 +129,9 @@
 #if SANITIZER_WINDOWS
 #include "sanitizer_common/sanitizer_platform.h"
 #define WIN32_LEAN_AND_MEAN
-#define NOMINMAX
-#include <windows.h>
-#include <psapi.h>
+#  define NOMINMAX
+#  include <windows.h>
+#  include <psapi.h>
 
 namespace __interception {
 
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_unwind_win.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_unwind_win.cpp
index 83574ec24..73c155386 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_unwind_win.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_unwind_win.cpp
@@ -15,12 +15,12 @@
 
 #define WIN32_LEAN_AND_MEAN
 #define NOGDI
-#define NOMINMAX
-#include <windows.h>
+#  define NOMINMAX
+#  include <windows.h>
 
-#include "sanitizer_dbghelp.h"  // for StackWalk64
-#include "sanitizer_stacktrace.h"
-#include "sanitizer_symbolizer.h"  // for InitializeDbgHelpIfNeeded
+#  include "sanitizer_dbghelp.h"  // for StackWalk64
+#  include "sanitizer_stacktrace.h"
+#  include "sanitizer_symbolizer.h"  // for InitializeDbgHelpIfNeeded
 
 using namespace __sanitizer;
 
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_win.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_win.cpp
index 97594e7b9..dbba79762 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_win.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_win.cpp
@@ -16,24 +16,24 @@
 
 #define WIN32_LEAN_AND_MEAN
 #define NOGDI
-#define NOMINMAX
-#include <windows.h>
-#include <io.h>
-#include <psapi.h>
-#include <stdlib.h>
-
-#include "sanitizer_common.h"
-#include "sanitizer_file.h"
-#include "sanitizer_libc.h"
-#include "sanitizer_mutex.h"
-#include "sanitizer_placement_new.h"
-#include "sanitizer_win_defs.h"
-
-#if defined(PSAPI_VERSION) && PSAPI_VERSION == 1
-#pragma comment(lib, "psapi")
-#endif
-#if SANITIZER_WIN_TRACE
-#include <traceloggingprovider.h>
+#  define NOMINMAX
+#  include <windows.h>
+#  include <io.h>
+#  include <psapi.h>
+#  include <stdlib.h>
+
+#  include "sanitizer_common.h"
+#  include "sanitizer_file.h"
+#  include "sanitizer_libc.h"
+#  include "sanitizer_mutex.h"
+#  include "sanitizer_placement_new.h"
+#  include "sanitizer_win_defs.h"
+
+#  if defined(PSAPI_VERSION) && PSAPI_VERSION == 1
+#    pragma comment(lib, "psapi")
+#  endif
+#  if SANITIZER_WIN_TRACE
+#    include <traceloggingprovider.h>
 //  Windows trace logging provider init
 #pragma comment(lib, "advapi32.lib")
 TRACELOGGING_DECLARE_PROVIDER(g_asan_provider);
diff --git a/compiler-rt/test/asan/TestCases/Windows/dll_heap_allocation.cpp b/compiler-rt/test/asan/TestCases/Windows/dll_heap_allocation.cpp
index e108043a1..596928332 100644
--- a/compiler-rt/test/asan/TestCases/Windows/dll_heap_allocation.cpp
+++ b/compiler-rt/test/asan/TestCases/Windows/dll_heap_allocation.cpp
@@ -8,8 +8,8 @@
 
 #ifdef HEAP_LIBRARY
 #include <memory>
-#define NOMINMAX
-#include <windows.h>
+#  define NOMINMAX
+#  include <windows.h>
 
 std::unique_ptr<int> __declspec(dllexport) myglobal(new int(42));
 BOOL WINAPI DllMain(PVOID h, DWORD reason, PVOID reserved) {
diff --git a/compiler-rt/test/asan/TestCases/exitcode.cpp b/compiler-rt/test/asan/TestCases/exitcode.cpp
index 3031e0d49..e06c829c3 100644
--- a/compiler-rt/test/asan/TestCases/exitcode.cpp
+++ b/compiler-rt/test/asan/TestCases/exitcode.cpp
@@ -10,8 +10,8 @@
 #include <stdio.h>
 
 #ifdef _WIN32
-#define NOMINMAX
-#include <windows.h>
+#  define NOMINMAX
+#  include <windows.h>
 
 int spawn_child(char **argv) {
   // Set an environment variable to tell the child process to interrupt
diff --git a/compiler-rt/test/asan/TestCases/ill.cpp b/compiler-rt/test/asan/TestCases/ill.cpp
index 402a13951..eea9189de 100644
--- a/compiler-rt/test/asan/TestCases/ill.cpp
+++ b/compiler-rt/test/asan/TestCases/ill.cpp
@@ -5,8 +5,8 @@
 // REQUIRES: x86-target-arch && (!MSVC || asan-32-bits)
 
 #ifdef _WIN32
-#define NOMINMAX
-#include <windows.h>
+#  define NOMINMAX
+#  include <windows.h>
 #endif
 
 // note: test is limited to i386 only ("asan-32-bits") when using "real" MSVC
diff --git a/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp b/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp
index a4671fdf5..c3a98c211 100644
--- a/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp
+++ b/libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp
@@ -35,8 +35,8 @@
 
 #include <fcntl.h>
 #ifdef _WIN32
-#define NOMINMAX
-#include <windows.h>
+#  define NOMINMAX
+#  include <windows.h>
 #else
 #include <sys/time.h>
 #include <sys/stat.h>
diff --git a/libcxxabi/src/cxa_personality.cpp b/libcxxabi/src/cxa_personality.cpp
index 91a67e339..0fb33fd51 100644
--- a/libcxxabi/src/cxa_personality.cpp
+++ b/libcxxabi/src/cxa_personality.cpp
@@ -68,9 +68,9 @@
 #endif
 
 #if defined(__SEH__) && !defined(__USING_SJLJ_EXCEPTIONS__)
-#define NOMINMAX
-#include <windows.h>
-#include <winnt.h>
+#  define NOMINMAX
+#  include <windows.h>
+#  include <winnt.h>
 
 extern "C" EXCEPTION_DISPOSITION _GCC_specific_handler(PEXCEPTION_RECORD,
                                                        void *, PCONTEXT,

``````````

</details>


https://github.com/llvm/llvm-project/pull/187414


More information about the libcxx-commits mailing list