[libcxx-commits] [libcxx] [libc++] Remove non-standard member type iterator_type from __wrap_iter (PR #186871)

A. Jiang via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 19 23:46:15 PDT 2026


================
@@ -58,6 +58,10 @@ Deprecations and Removals
 - ``__wrap_iter``'s (iterator type for ``array``, ``span``, ``string``, ``string_view`` and ``vector``) ``base()``
   method has been removed as it was non-standard.
 
+- Removed the non-standard member type ``iterator_type`` from ``__wrap_iter``.
+  This member exposed the underlying iterator type and its removal prevents
+  users from relying on the implementation detail.
----------------
frederick-vs-ja wrote:

> Is it not necessary to have the explanation?

I _think_ the explanation is unnecessary as we haven't said this before.

> On a side note, I will squash commits to prepare it for merge.

This is not necessary for the PR branch as we merge every PR as a squashed commit, and [it's recommended not to rebase the branch during review](https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes). 

https://github.com/llvm/llvm-project/pull/186871


More information about the libcxx-commits mailing list