[libcxx-commits] [libcxx] [libc++] Fix unnecessary flushes in std::print() on POSIX (PR #70321)
Nikolas Klauser via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Mar 9 12:46:41 PDT 2026
================
@@ -16,10 +16,10 @@
// When std::print is unavailable, we don't rely on an implementation of
// std::__is_terminal and we always assume a non-unicode and non-terminal
// output.
-// XFAIL: availability-print-missing
+// XFAIL: availability-print-missing && target={{.*}}-windows{{.*}}
// Clang modules do not work with the definiton of _LIBCPP_TESTING_PRINT_IS_TERMINAL
-// XFAIL: clang-modules-build
+// XFAIL: clang-modules-build && target={{.*}}-windows{{.*}}
----------------
philnik777 wrote:
I think it'd be better to simply add `// ADDITIONAL_COMPILE_FLAGS: -fno-modules` unconditionally. Then we're sure this actually works as expected (which it definitely doesn't right now) and the modules build is actually correct and doesn't just happen to work out.
https://github.com/llvm/llvm-project/pull/70321
More information about the libcxx-commits
mailing list