[libcxx-commits] [libcxx] d7ff97d - [libc++] Support build failures when running LNT benchmarks (#185234)

via libcxx-commits libcxx-commits at lists.llvm.org
Sat Mar 7 14:23:16 PST 2026


Author: Louis Dionne
Date: 2026-03-07T22:23:11Z
New Revision: d7ff97db15026860f1f9c95e8fbf9f81e7120be3

URL: https://github.com/llvm/llvm-project/commit/d7ff97db15026860f1f9c95e8fbf9f81e7120be3
DIFF: https://github.com/llvm/llvm-project/commit/d7ff97db15026860f1f9c95e8fbf9f81e7120be3.diff

LOG: [libc++] Support build failures when running LNT benchmarks (#185234)

It's rare but possible for the codebase not to build. When that happens,
we should carry on and still submit an empty LNT report for that order,
otherwise we'll get stuck thinking that order hasn't been benchmarked
yet.

Added: 
    

Modified: 
    libcxx/utils/ci/lnt/run-benchmarks

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/ci/lnt/run-benchmarks b/libcxx/utils/ci/lnt/run-benchmarks
index 40c58eaff54e7..256871b6a8576 100755
--- a/libcxx/utils/ci/lnt/run-benchmarks
+++ b/libcxx/utils/ci/lnt/run-benchmarks
@@ -127,11 +127,12 @@ def main(argv):
         run([build_dir / '.venv/bin/pip', 'install', 'llvm-lnt'])
 
         logging.info(f'Building libc++ at commit {args.benchmark_commit}')
-        run([args.git_repo / 'libcxx/utils/build-at-commit',
+        build_cmd = [args.git_repo / 'libcxx/utils/build-at-commit',
                         '--git-repo', args.git_repo,
                         '--install-dir', build_dir / 'install',
                         '--commit', args.benchmark_commit,
-                        '--', '-DCMAKE_BUILD_TYPE=RelWithDebInfo', f'-DCMAKE_CXX_COMPILER={args.compiler}'])
+                        '--', '-DCMAKE_BUILD_TYPE=RelWithDebInfo', f'-DCMAKE_CXX_COMPILER={args.compiler}']
+        run(build_cmd, enforce_success=False) # if the build fails, carry on: we'll fail later and submit empty LNT results
 
         logging.info(f'Running benchmarks from {args.test_suite_commit} against libc++ {args.benchmark_commit}')
         cmd = [args.git_repo / 'libcxx/utils/test-at-commit',


        


More information about the libcxx-commits mailing list