[libcxx-commits] [libcxx] [libc++] Support build failures when running LNT benchmarks (PR #185234)

[via libcxx-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

<details>
<summary>Changes</summary>

It's rare but possible for the codebase not to build. When that happens, we should carry on and still submit an empty LNT report for that order, otherwise we'll get stuck thinking that order hasn't been benchmarked yet.

---
Full diff: https://github.com/llvm/llvm-project/pull/185234.diff


1 Files Affected:

- (modified) libcxx/utils/ci/lnt/run-benchmarks (+3-2) 


``````````diff
diff --git a/libcxx/utils/ci/lnt/run-benchmarks b/libcxx/utils/ci/lnt/run-benchmarks
index 40c58eaff54e7..256871b6a8576 100755
--- a/libcxx/utils/ci/lnt/run-benchmarks
+++ b/libcxx/utils/ci/lnt/run-benchmarks
@@ -127,11 +127,12 @@ def main(argv):
         run([build_dir / '.venv/bin/pip', 'install', 'llvm-lnt'])
 
         logging.info(f'Building libc++ at commit {args.benchmark_commit}')
-        run([args.git_repo / 'libcxx/utils/build-at-commit',
+        build_cmd = [args.git_repo / 'libcxx/utils/build-at-commit',
                         '--git-repo', args.git_repo,
                         '--install-dir', build_dir / 'install',
                         '--commit', args.benchmark_commit,
-                        '--', '-DCMAKE_BUILD_TYPE=RelWithDebInfo', f'-DCMAKE_CXX_COMPILER={args.compiler}'])
+                        '--', '-DCMAKE_BUILD_TYPE=RelWithDebInfo', f'-DCMAKE_CXX_COMPILER={args.compiler}']
+        run(build_cmd, enforce_success=False) # if the build fails, carry on: we'll fail later and submit empty LNT results
 
         logging.info(f'Running benchmarks from {args.test_suite_commit} against libc++ {args.benchmark_commit}')
         cmd = [args.git_repo / 'libcxx/utils/test-at-commit',

``````````

</details>


https://github.com/llvm/llvm-project/pull/185234