[libcxx-commits] [libcxx] [libc++][test] XFAIL `text/text_encoding/environment.pass.cpp` test on Armv7/Linux Ubuntu targets. (PR #206188)

[William Tran-Viet via libcxx-commits]

smallp-o-p wrote:

For a quick rundown as to _why_ the test is failing, the `text_encoding::environment()` test is checking that the system's environment text encoding is ASCII (`id == 3`), which is what is set on the CI using Linux because it's defaulted to that. The official spec says to return the text encoding associated with the POSIX/"C" locale.

Now, the unfortunate thing for us is that on Linux, the system's text encoding can be manipulated by setting the `LANG` environment variable, meaning you can set it to something like `en_US.UTF-8` and now the test is making a faulty assumption because your system's text encoding is actually UTF-8 and not ASCII. If I were to guess for a system that's failing this test, that would be the cause.

It's likely I'll come back to rewrite the test in a more system-aware manner, but I'd have to figure out more of lit to do so.

https://github.com/llvm/llvm-project/pull/206188