[libcxx-commits] [libcxx] [libc++] Implement P2442R1 `std::views::chunk` (PR #171234)

[Hristo Hristov via libcxx-commits]

https://github.com/Zingam requested changes to this pull request.

I did a quick review of the `[[nodiscard]]` application and the related tests cases. 
These are tracked here: https://github.com/llvm/llvm-project/issues/172124 but since this is a new PR we don't need to track it there but you can use it as a reference.

All comments bellow are also relevant to: https://github.com/llvm/llvm-project/pull/172948
Please update both PRs so I don't have to bother you with the same comments twice.

Also note that most `[[nodiscard]]` tests are implemented in a style to ease the review, which means all test cases were added in the test in the same order as they appear in the header and also if split in multiple files ordered by files.

FYI: Please also make sure to "complete" your PR and get the CI green before you ask for a review as some reviewers might not review it before if the PR is draft or the CI found errors.

https://github.com/llvm/llvm-project/pull/171234