[libcxx-commits] [libcxx] [libcxx][test-support] Implement fancy_pointer_allocator (PR #196187)

[Nikita Belenkiy via libcxx-commits]

================
@@ -32,11 +32,7 @@ int main(int, char**) {
   }
   {
     typedef std::basic_string<char, std::char_traits<char>, limited_allocator<char, 10>> C;
-#if TEST_STD_VER <= 14
----------------
kitsnet wrote:

This (and the rest of the stuff related to the changes in `thread_unsafe_shared_ptr`) is better to be discussed in https://github.com/llvm/llvm-project/pull/195932 .
We also have https://github.com/llvm/llvm-project/pull/197912 and https://github.com/llvm/llvm-project/pull/166397 approaching the same (or related) problem from different angles.

Basically, due to (likely) some sloppiness in coding of `thread_unsafe_shared_ptr`, one of our test allocators (`limited_allocator`) was failing this test when compiled with C++11/C++14. It looks like instead of fixing the allocator, someone "fixed" the test.

https://github.com/llvm/llvm-project/pull/196187