[libcxx-commits] [libcxx] WIP [libc++][ranges] Applied [[nodiscard]] to `adjacent_view` (PR #205206)

A. Jiang via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 25 03:54:30 PDT 2026


https://github.com/frederick-vs-ja requested changes to this pull request.

> I think most tests are there. I probably still have to think about a proper view (or views) to test the different `__simple_view<_View>`and `common_range<_View>` permutations:

I think we can use the view suggested in https://github.com/llvm/llvm-project/pull/204014#discussion_r3463575295 to verify different iterator/sentinel types.

> Also, I think I am not allowed to put the label `libc++` into the PR desc. Is it something you manually do yourselves? Thanks!

The label will be automatically added by a bot, so we generally don't need to care about it. Although members can modify the labels.

https://github.com/llvm/llvm-project/pull/205206


More information about the libcxx-commits mailing list