[libcxx-commits] [libcxx] [libc++] Move <features.h> include to <__configuration/platform.h> (PR #205548)

via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 24 06:14:50 PDT 2026


llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Nikolas Klauser (philnik777)

<details>
<summary>Changes</summary>

Including `<features.h>` is platform-specific configuration and should therefore be in `<__configuration/platform.h>`.


---
Full diff: https://github.com/llvm/llvm-project/pull/205548.diff


1 Files Affected:

- (modified) libcxx/include/__configuration/platform.h (+4) 


``````````diff
diff --git a/libcxx/include/__configuration/platform.h b/libcxx/include/__configuration/platform.h
index 644fe1724e42e..ebd638e663215 100644
--- a/libcxx/include/__configuration/platform.h
+++ b/libcxx/include/__configuration/platform.h
@@ -30,6 +30,10 @@
 // ... add new file formats here ...
 #endif
 
+#if defined(__MVS__)
+#  include <features.h> // for __NATIVE_ASCII_F
+#endif
+
 // Need to detect which libc we're using if we're on Linux.
 #if (defined(__linux__) || defined(__AMDGPU__) || defined(__NVPTX__)) && __has_include(<features.h>)
 #  include <features.h>

``````````

</details>


https://github.com/llvm/llvm-project/pull/205548


More information about the libcxx-commits mailing list