[libcxx-commits] [libcxx] [libc++] Don't make libc++ headers system headers in the modulemap (PR #205509)

[via libcxx-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions ,cpp -- libcxx/include/__locale libcxx/include/syncstream libcxx/test/std/depr/depr.cpp.headers/ccomplex.verify.cpp libcxx/test/std/depr/depr.cpp.headers/ciso646.verify.cpp libcxx/test/std/depr/depr.cpp.headers/cstdalign.verify.cpp libcxx/test/std/depr/depr.cpp.headers/cstdbool.verify.cpp libcxx/test/std/depr/depr.cpp.headers/ctgmath.verify.cpp libcxx/test/std/library/description/conventions/expos.only.func/synth_three_way.pass.cpp libcxx/test/std/ranges/range.factories/range.iota.view/ctor.value.bound.pass.cpp libcxx/test/std/ranges/range.factories/range.iota.view/end.pass.cpp libcxx/test/std/utilities/tuple/tuple.tuple/tuple.rel/three_way.pass.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/include/__locale b/libcxx/include/__locale
index e83339472..a87c02f09 100644
--- a/libcxx/include/__locale
+++ b/libcxx/include/__locale
@@ -325,8 +325,8 @@ public:
 #    endif // defined(__BIONIC__)
 #  elif defined(__GLIBC__)
   typedef unsigned short mask;
-_LIBCPP_DIAGNOSTIC_PUSH
-_LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wmodules-ambiguous-internal-linkage")
+  _LIBCPP_DIAGNOSTIC_PUSH
+  _LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wmodules-ambiguous-internal-linkage")
   static const mask space  = _ISspace;
   static const mask print  = _ISprint;
   static const mask cntrl  = _IScntrl;
@@ -337,7 +337,7 @@ _LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wmodules-ambiguous-internal-linkage")
   static const mask punct  = _ISpunct;
   static const mask xdigit = _ISxdigit;
   static const mask blank  = _ISblank;
-_LIBCPP_DIAGNOSTIC_POP
+  _LIBCPP_DIAGNOSTIC_POP
 #    if defined(__mips__) || (BYTE_ORDER == BIG_ENDIAN)
   static const mask __regex_word = static_cast<mask>(_ISbit(15));
 #    else

``````````

</details>


https://github.com/llvm/llvm-project/pull/205509