[libcxx-commits] [libcxx] [libc++] Diagnose unused variables of container types (PR #203084)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> @philnik Lastly, a meta point: I think it's reasonable that you didn't see value in a PR description at first. However, I think it makes sense and is more productive to provide one especially when requested to do so. There's ample precedent in libc++ and LLVM for putting some effort into commit messages/PR descriptions, and I think it makes sense to hold everyone to the same standard. Generally speaking, I think a good litmus test is to think of how we'd react to a first time contributor submitting the same patch. I know that as far as I am concerned, I would have been annoyed if a first time contributor submitted a PR without proper message explaining the rationale/benefits, and I would have requested a description as well.

I don't disagree, which is why I put the part that I thought might actually be useful in the description. This was a genuine question of what someone wants. I'm aware that I tend to be somewhat short on commit messages. However, I have either given reasons for why I personally wouldn't want to see stuff in the description (generally, the longer it is the less likely it is that I'm going to read it - especially if it contains stuff like long diagnostic output) or have added information.

https://github.com/llvm/llvm-project/pull/203084