[libcxx-commits] [libcxx] [libc++] P3798R1: The unexpected in std::expected (PR #204826)

[Hristo Hristov via libcxx-commits]

Zingam wrote:

> > @godexsoft I have slightly modified the title and the top comment to link this PR to the GitHub issue. You still should update the commit message (as discussed above) to the libc++'s conventions before committing.
> 
> Ok i have applied modifications as you suggested. Few caveats:
> 
> * I have not found any real/specific documentation about the "top comment" formatting other than that the contents should be concise and only talk about the code implemented. Please point me to any such documentation if it exists and if i still got the "top comment" wrong.
> * I was able to build llvm locally but running the testsuite did not appear to include `std-at-least-c++29` stuff, probably because it's not configured to do so. I am also not sure if my added tests are GLOBed or i needed to list them somewhere to even build them. Please advise as appropriate 🙏
> * Because of the above, i'm not sure if my test code is correct and/or what you expected. Please recommend changes.. Alternatively, help with building and running the new tests locally would be greatly appreciated.
> 
> I'm fine to park this until C++29 support is ready. Will i be notified automatically (if we setup some label or something?) or should i be monitoring it myself? if it's the latter then please advise where to monitor this 🙇

I guess since you should implement this as DR, you don't need to wait for the C++29 support.

https://github.com/llvm/llvm-project/pull/204826