[libcxx-commits] [libcxx] [libc++] p3798: expected::has_error (PR #204826)

[Hristo Hristov via libcxx-commits]

Zingam wrote:

> > Please prefix the title with `[libc++]`, which is our convention. I guess we don't support C++29 in the codebase yet. (It is too new and nobody has added it yet.)
> > Please note that the top comment becomes the commit message and it should contain just relevant information regarding the implementation. You can put anything else in follow-up comments.
> 
> Updated the title, thanks. For the second part, you mean the "description", right? Can this be updated later when we move from Draft and open the PR? I assume c++29 should be added in a separate PR, right? So this probably needs to wait until then. I'm happy to do the other PR too but i could not find how 🙂

Enabling C++29 will also require setting up the CI + (I guess) compiler support/flag, so it may take a while. You can finish this PR as is and park it until we get everything working.

https://github.com/llvm/llvm-project/pull/204826