[libcxx-commits] [libcxx] [libc++][string] Add constexpr initialization stress test (PR #184723)

[Louis Dionne via libcxx-commits]

https://github.com/ldionne requested changes to this pull request.

I don't think we should go ahead with this, or with #184724. It's not that I don't like constexpr efficiency, but this seems to be making a pretty arbitrary change to raise the limit from some arbitrary point to another arbitrary point. This does not meaningfully improve or document the guarantees provided by the library (and in fact I don't think it makes sense to aim for a specific guarantee in this domain).

As @AaronBallman said in https://github.com/llvm/llvm-project/pull/184724#issuecomment-4092286596, these steps are arbitrary and I don't think it makes sense for libc++ to try to provide guarantees about something so arbitrary.

https://github.com/llvm/llvm-project/pull/184723