[libcxx-commits] [libcxx] [libcxx] Do not mark mkstemp tests xfail for libc (PR #203681)

via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jun 13 00:27:22 PDT 2026 

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Aiden Grossman (boomanaiden154)

<details>
<summary>Changes</summary>

mkstemp was recently implemented in
c9b25a6437fd97fdb1e55ab6661c0cccce98913e, so these tests now pass.

---
Full diff: https://github.com/llvm/llvm-project/pull/203681.diff


12 Files Affected:

- (modified) libcxx/test/std/containers/container.adaptors/container.adaptors.format/format.functions.format.pass.cpp (-3) 
- (modified) libcxx/test/std/containers/container.adaptors/container.adaptors.format/format.functions.vformat.pass.cpp (-3) 
- (modified) libcxx/test/std/utilities/format/format.range/format.range.fmtmap/format.functions.format.pass.cpp (-3) 
- (modified) libcxx/test/std/utilities/format/format.range/format.range.fmtmap/format.functions.vformat.pass.cpp (-3) 
- (modified) libcxx/test/std/utilities/format/format.range/format.range.fmtset/format.functions.format.pass.cpp (-3) 
- (modified) libcxx/test/std/utilities/format/format.range/format.range.fmtset/format.functions.vformat.pass.cpp (-3) 
- (modified) libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.functions.format.pass.cpp (-3) 
- (modified) libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.functions.vformat.pass.cpp (-3) 
- (modified) libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.pass.cpp (-3) 
- (modified) libcxx/test/std/utilities/format/format.range/format.range.fmtstr/parse.pass.cpp (-3) 
- (modified) libcxx/test/std/utilities/format/format.range/format.range.formatter/format.functions.format.pass.cpp (-3) 
- (modified) libcxx/test/std/utilities/format/format.range/format.range.formatter/format.functions.vformat.pass.cpp (-3) 


``````````diff
diff --git a/libcxx/test/std/containers/container.adaptors/container.adaptors.format/format.functions.format.pass.cpp b/libcxx/test/std/containers/container.adaptors/container.adaptors.format/format.functions.format.pass.cpp
index 3f210aca6b436..6d2a5ecbb5ecf 100644
--- a/libcxx/test/std/containers/container.adaptors/container.adaptors.format/format.functions.format.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/container.adaptors.format/format.functions.format.pass.cpp
@@ -12,9 +12,6 @@
 
 // XFAIL: availability-fp_to_chars-missing
 
-// Missing mkstemp
-// XFAIL: LLVM-LIBC-FIXME
-
 // [container.adaptors.format]
 // For each of queue, priority_queue, and stack, the library provides the
 // following formatter specialization where adaptor-type is the name of the
diff --git a/libcxx/test/std/containers/container.adaptors/container.adaptors.format/format.functions.vformat.pass.cpp b/libcxx/test/std/containers/container.adaptors/container.adaptors.format/format.functions.vformat.pass.cpp
index 21aab0a2c2f94..c6f1815de9c57 100644
--- a/libcxx/test/std/containers/container.adaptors/container.adaptors.format/format.functions.vformat.pass.cpp
+++ b/libcxx/test/std/containers/container.adaptors/container.adaptors.format/format.functions.vformat.pass.cpp
@@ -12,9 +12,6 @@
 
 // XFAIL: availability-fp_to_chars-missing
 
-// Missing mkstemp
-// XFAIL: LLVM-LIBC-FIXME
-
 // [container.adaptors.format]
 // For each of queue, priority_queue, and stack, the library provides the
 // following formatter specialization where adaptor-type is the name of the
diff --git a/libcxx/test/std/utilities/format/format.range/format.range.fmtmap/format.functions.format.pass.cpp b/libcxx/test/std/utilities/format/format.range/format.range.fmtmap/format.functions.format.pass.cpp
index e6691a57f2d11..d64e9a6dc2a8a 100644
--- a/libcxx/test/std/utilities/format/format.range/format.range.fmtmap/format.functions.format.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.range/format.range.fmtmap/format.functions.format.pass.cpp
@@ -12,9 +12,6 @@
 
 // XFAIL: availability-fp_to_chars-missing
 
-// Missing mkstemp
-// XFAIL: LLVM-LIBC-FIXME
-
 // <format>
 
 // template<ranges::input_range R, class charT>
diff --git a/libcxx/test/std/utilities/format/format.range/format.range.fmtmap/format.functions.vformat.pass.cpp b/libcxx/test/std/utilities/format/format.range/format.range.fmtmap/format.functions.vformat.pass.cpp
index 1529b6ee65beb..93745cfbbdaaf 100644
--- a/libcxx/test/std/utilities/format/format.range/format.range.fmtmap/format.functions.vformat.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.range/format.range.fmtmap/format.functions.vformat.pass.cpp
@@ -12,9 +12,6 @@
 
 // XFAIL: availability-fp_to_chars-missing
 
-// Missing mkstemp
-// XFAIL: LLVM-LIBC-FIXME
-
 // <format>
 
 // template<ranges::input_range R, class charT>
diff --git a/libcxx/test/std/utilities/format/format.range/format.range.fmtset/format.functions.format.pass.cpp b/libcxx/test/std/utilities/format/format.range/format.range.fmtset/format.functions.format.pass.cpp
index 0f92158fffe5c..98097cfbda9e1 100644
--- a/libcxx/test/std/utilities/format/format.range/format.range.fmtset/format.functions.format.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.range/format.range.fmtset/format.functions.format.pass.cpp
@@ -12,9 +12,6 @@
 
 // XFAIL: availability-fp_to_chars-missing
 
-// Missing mkstemp
-// XFAIL: LLVM-LIBC-FIXME
-
 // <format>
 
 // template<ranges::input_range R, class charT>
diff --git a/libcxx/test/std/utilities/format/format.range/format.range.fmtset/format.functions.vformat.pass.cpp b/libcxx/test/std/utilities/format/format.range/format.range.fmtset/format.functions.vformat.pass.cpp
index 9a4a0f763b707..6afae316b2003 100644
--- a/libcxx/test/std/utilities/format/format.range/format.range.fmtset/format.functions.vformat.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.range/format.range.fmtset/format.functions.vformat.pass.cpp
@@ -12,9 +12,6 @@
 
 // XFAIL: availability-fp_to_chars-missing
 
-// Missing mkstemp
-// XFAIL: LLVM-LIBC-FIXME
-
 // <format>
 
 // template<ranges::input_range R, class charT>
diff --git a/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.functions.format.pass.cpp b/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.functions.format.pass.cpp
index f003123a417be..5fc9f94f03ac0 100644
--- a/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.functions.format.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.functions.format.pass.cpp
@@ -12,9 +12,6 @@
 
 // XFAIL: availability-fp_to_chars-missing
 
-// Missing mkstemp
-// XFAIL: LLVM-LIBC-FIXME
-
 // <format>
 
 // template<ranges::input_range R, class charT>
diff --git a/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.functions.vformat.pass.cpp b/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.functions.vformat.pass.cpp
index 9a464e6e38d13..2328a72d2f91e 100644
--- a/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.functions.vformat.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.functions.vformat.pass.cpp
@@ -12,9 +12,6 @@
 
 // XFAIL: availability-fp_to_chars-missing
 
-// Missing mkstemp
-// XFAIL: LLVM-LIBC-FIXME
-
 // <format>
 
 // template<ranges::input_range R, class charT>
diff --git a/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.pass.cpp b/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.pass.cpp
index 3b8dea6031470..7d6502e826cd4 100644
--- a/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/format.pass.cpp
@@ -8,9 +8,6 @@
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
 
-// Missing mkstemp
-// XFAIL: LLVM-LIBC-FIXME
-
 // <format>
 
 // template<ranges::input_range R, class charT>
diff --git a/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/parse.pass.cpp b/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/parse.pass.cpp
index 54332754de6f6..2317507c95275 100644
--- a/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/parse.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.range/format.range.fmtstr/parse.pass.cpp
@@ -8,9 +8,6 @@
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
 
-// Missing mkstemp
-// XFAIL: LLVM-LIBC-FIXME
-
 // <format>
 
 // template<ranges::input_range R, class charT>
diff --git a/libcxx/test/std/utilities/format/format.range/format.range.formatter/format.functions.format.pass.cpp b/libcxx/test/std/utilities/format/format.range/format.range.formatter/format.functions.format.pass.cpp
index eb267637a0411..a0b8aed3a33d2 100644
--- a/libcxx/test/std/utilities/format/format.range/format.range.formatter/format.functions.format.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.range/format.range.formatter/format.functions.format.pass.cpp
@@ -12,9 +12,6 @@
 
 // XFAIL: availability-fp_to_chars-missing
 
-// Missing mkstemp
-// XFAIL: LLVM-LIBC-FIXME
-
 // <format>
 
 //  template<class T, class charT = char>
diff --git a/libcxx/test/std/utilities/format/format.range/format.range.formatter/format.functions.vformat.pass.cpp b/libcxx/test/std/utilities/format/format.range/format.range.formatter/format.functions.vformat.pass.cpp
index 9d206312f3c75..9b43a225492e8 100644
--- a/libcxx/test/std/utilities/format/format.range/format.range.formatter/format.functions.vformat.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.range/format.range.formatter/format.functions.vformat.pass.cpp
@@ -12,9 +12,6 @@
 
 // XFAIL: availability-fp_to_chars-missing
 
-// Missing mkstemp
-// XFAIL: LLVM-LIBC-FIXME
-
 // <format>
 
 //  template<class T, class charT = char>

``````````

</details>


https://github.com/llvm/llvm-project/pull/203681

More information about the libcxx-commits mailing list