[libcxx-commits] [libcxx] [libc++] Strengthen optional value constructor noexcept (PR #202765)

[Louis Dionne via libcxx-commits]

https://github.com/ldionne commented:

> I assume such strengthening isn't an isolated instance and would like general guidance on whether this type of changes are acceptable for libc++.

We do have some places where we do that already, indeed. As it happens, I was doing a full survey of those places no later than today. However, we don't have a systematic criteria for applying these strengthenings at the moment. So, is it acceptable? Yes, at least it's definitely not unacceptable. However, if someone planned to add a lot of these strenghtenings, then we should write up some guideline first.

In this case, I'm tempted to take this patch as a one-off since it's correct and we have no reason to push back.

https://github.com/llvm/llvm-project/pull/202765