[libcxx-commits] [libcxx] [libc++] Harmonize header inclusion for all sorts of subsetting (PR #202246)

[Louis Dionne via libcxx-commits]

https://github.com/ldionne commented:

I see you went all the way. I was independently working on a solution where I make the header tests pass (for example `double-include` & friends), without pinning down the full set of transitive includes. Indeed, after looking into it more, I am not convinced that there is value in providing a stable set of transitive includes when the carve-outs like `no-localization` are active. However, it should still be valid to include the header (and the header would potentially be empty). Does that make sense?

I think relaxing the need for transitive includes to be stable when carve-outs are active would simplify most of your PR -- you wouldn't need to move around includes so they appear before `#if _LIBCPP_STD_VER > x`.

https://github.com/llvm/llvm-project/pull/202246