[libcxx-commits] [libcxx] [libc++][span][test] Various cleanups for <span> tests (PR #202319)

[via libcxx-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- libcxx/test/std/containers/views/views.span/enable_borrowed_range.compile.pass.cpp libcxx/test/std/containers/views/views.span/range_concept_conformance.compile.pass.cpp libcxx/test/std/containers/views/views.span/span.cons/array.pass.cpp libcxx/test/std/containers/views/views.span/span.cons/assign.pass.cpp libcxx/test/std/containers/views/views.span/span.cons/copy.pass.cpp libcxx/test/std/containers/views/views.span/span.cons/deduct.pass.cpp libcxx/test/std/containers/views/views.span/span.cons/default.pass.cpp libcxx/test/std/containers/views/views.span/span.cons/initializer_list.pass.cpp libcxx/test/std/containers/views/views.span/span.cons/iterator_len.pass.cpp libcxx/test/std/containers/views/views.span/span.cons/iterator_len.verify.cpp libcxx/test/std/containers/views/views.span/span.cons/iterator_sentinel.pass.cpp libcxx/test/std/containers/views/views.span/span.cons/iterator_sentinel.verify.cpp libcxx/test/std/containers/views/views.span/span.cons/range.pass.cpp libcxx/test/std/containers/views/views.span/span.cons/span.dtor.compile.pass.cpp libcxx/test/std/containers/views/views.span/span.cons/span.pass.cpp libcxx/test/std/containers/views/views.span/span.cons/span.verify.cpp libcxx/test/std/containers/views/views.span/span.cons/stdarray.pass.cpp libcxx/test/std/containers/views/views.span/span.elem/at.pass.cpp libcxx/test/std/containers/views/views.span/span.elem/back.pass.cpp libcxx/test/std/containers/views/views.span/span.elem/data.pass.cpp libcxx/test/std/containers/views/views.span/span.elem/front.pass.cpp libcxx/test/std/containers/views/views.span/span.elem/op_idx.pass.cpp libcxx/test/std/containers/views/views.span/span.iterators/begin.pass.cpp libcxx/test/std/containers/views/views.span/span.iterators/end.pass.cpp libcxx/test/std/containers/views/views.span/span.iterators/iterator.pass.cpp libcxx/test/std/containers/views/views.span/span.iterators/iterator_concept_conformance.compile.pass.cpp libcxx/test/std/containers/views/views.span/span.iterators/rbegin.pass.cpp libcxx/test/std/containers/views/views.span/span.iterators/rend.pass.cpp libcxx/test/std/containers/views/views.span/span.objectrep/as_bytes.pass.cpp libcxx/test/std/containers/views/views.span/span.objectrep/as_writable_bytes.pass.cpp libcxx/test/std/containers/views/views.span/span.obs/empty.nodiscard.verify.cpp libcxx/test/std/containers/views/views.span/span.obs/empty.pass.cpp libcxx/test/std/containers/views/views.span/span.obs/size.pass.cpp libcxx/test/std/containers/views/views.span/span.obs/size_bytes.pass.cpp libcxx/test/std/containers/views/views.span/trivially_copyable.compile.pass.cpp libcxx/test/std/containers/views/views.span/types.pass.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/test/std/containers/views/views.span/span.cons/array.pass.cpp b/libcxx/test/std/containers/views/views.span/span.cons/array.pass.cpp
index cbc51f476..00d55f60e 100644
--- a/libcxx/test/std/containers/views/views.span/span.cons/array.pass.cpp
+++ b/libcxx/test/std/containers/views/views.span/span.cons/array.pass.cpp
@@ -115,39 +115,39 @@ int main() {
 
   // Size wrong
   {
-    static_assert(!std::is_constructible_v<std::span<int, 2>, int(&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<int, 2>, int (&)[3]>);
   }
 
   // Type wrong
   {
-    static_assert(!std::is_constructible_v<std::span<float>, int(&)[3]>);
-    static_assert(!std::is_constructible_v<std::span<float, 3>, int(&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<float>, int (&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<float, 3>, int (&)[3]>);
   }
 
   // CV wrong (dynamically sized)
   {
-    static_assert(!std::is_constructible_v<std::span<int>, const int(&)[3]>);
-    static_assert(!std::is_constructible_v<std::span<int>, volatile int(&)[3]>);
-    static_assert(!std::is_constructible_v<std::span<int>, const volatile int(&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<int>, const int (&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<int>, volatile int (&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<int>, const volatile int (&)[3]>);
 
-    static_assert(!std::is_constructible_v<std::span<const int>, volatile int(&)[3]>);
-    static_assert(!std::is_constructible_v<std::span<const int>, const volatile int(&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<const int>, volatile int (&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<const int>, const volatile int (&)[3]>);
 
-    static_assert(!std::is_constructible_v<std::span<volatile int>, const int(&)[3]>);
-    static_assert(!std::is_constructible_v<std::span<volatile int>, const volatile int(&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<volatile int>, const int (&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<volatile int>, const volatile int (&)[3]>);
   }
 
   // CV wrong (statically sized)
   {
-    static_assert(!std::is_constructible_v<std::span<int, 3>, const int(&)[3]>);
-    static_assert(!std::is_constructible_v<std::span<int, 3>, volatile int(&)[3]>);
-    static_assert(!std::is_constructible_v<std::span<int, 3>, const volatile int(&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<int, 3>, const int (&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<int, 3>, volatile int (&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<int, 3>, const volatile int (&)[3]>);
 
-    static_assert(!std::is_constructible_v<std::span<const int, 3>, volatile int(&)[3]>);
-    static_assert(!std::is_constructible_v<std::span<const int, 3>, const volatile int(&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<const int, 3>, volatile int (&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<const int, 3>, const volatile int (&)[3]>);
 
-    static_assert(!std::is_constructible_v<std::span<volatile int, 3>, const int(&)[3]>);
-    static_assert(!std::is_constructible_v<std::span<volatile int, 3>, const volatile int(&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<volatile int, 3>, const int (&)[3]>);
+    static_assert(!std::is_constructible_v<std::span<volatile int, 3>, const volatile int (&)[3]>);
   }
 
   return 0;
diff --git a/libcxx/test/std/containers/views/views.span/span.cons/stdarray.pass.cpp b/libcxx/test/std/containers/views/views.span/span.cons/stdarray.pass.cpp
index 9f218e5a2..472f8ac8d 100644
--- a/libcxx/test/std/containers/views/views.span/span.cons/stdarray.pass.cpp
+++ b/libcxx/test/std/containers/views/views.span/span.cons/stdarray.pass.cpp
@@ -50,10 +50,10 @@ void checkCV() {
 
   //  types different (static sized)
   {
-    std::span<const int, 3> s1{arr};           // a span<const int> pointing at int.
-    std::span<volatile int, 3> s2{arr};        // a span<volatile int> pointing at int.
-    std::span<volatile int, 3> s3{arr};        // a span<volatile int> pointing at const int.
-    std::span<const volatile int, 3> s4{arr};  // a span<const volatile int> pointing at int.
+    std::span<const int, 3> s1{arr};          // a span<const int> pointing at int.
+    std::span<volatile int, 3> s2{arr};       // a span<volatile int> pointing at int.
+    std::span<volatile int, 3> s3{arr};       // a span<volatile int> pointing at const int.
+    std::span<const volatile int, 3> s4{arr}; // a span<const volatile int> pointing at int.
   }
 }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/202319