[libcxx-commits] [libcxx] [libc++] Regenerate transitive include. (PR #202001)
Connector Switch via libcxx-commits
libcxx-commits at lists.llvm.org
Sat Jun 6 23:23:28 PDT 2026
c8ef wrote:
> `<barrier>` and `<stop_token>` are added in C++20 (via [P1153R6](https://wg21.link/p1135r6) and [P0660R10](https://wg21.link/p0660r10)), while this PR touches data for pre-C++20 modes.
>
> IIUC we just mark tests for them UNSUPPORTED before C++20. So all tests have been passing.
>
So it looks like there's a mismatch between generation and verification? If we don't verify them, perhaps we shouldn't generate them in the first place?
> https://github.com/llvm/llvm-project/blob/a0344e9f990d503274662b9cbf7f15b7ad92a3e9/libcxx/utils/libcxx/header_information.py#L179
>
>
> https://github.com/llvm/llvm-project/blob/a0344e9f990d503274662b9cbf7f15b7ad92a3e9/libcxx/utils/libcxx/header_information.py#L196
>
> I believe this PR makes sense only if we want to support including `<barrier>` and `<stop_token>` before C++20 mode.
I'm a bit confused by the `only if` logic. This PR doesn't add new headers; it simply updates the existing ones.
https://github.com/llvm/llvm-project/pull/202001
More information about the libcxx-commits
mailing list