[libcxx-commits] [libcxx] [libc++] Don't rely on a transitively included BYTE_ORDER in ctype_base (PR #213032)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jul 31 03:41:51 PDT 2026


https://github.com/philnik777 approved this pull request.

> > I'm kinda wondering whether we shouldn't replace `_LIBCPP_BIG_ENDIAN` with `BYTE_ORDER == BIT_ENDIAN` instead. Our policy tends to be to use standard facilities where applicable, and I think that is the case here as well.
> 
> `BYTE_ORDER == BIG_ENDIAN` is not standard AFAICT?

Huh, looks like it's POSIX: https://pubs.opengroup.org/onlinepubs/9799919799.2024edition/basedefs/endian.h.html. Then never mind.

https://github.com/llvm/llvm-project/pull/213032


More information about the libcxx-commits mailing list